netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] netfilter: core: make local function __nf_unregister_net_hook static
@ 2018-01-10  7:05 Wei Yongjun
  2018-01-10 13:41 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2018-01-10  7:05 UTC (permalink / raw)
  To: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal
  Cc: Wei Yongjun, netfilter-devel, coreteam, netdev

Fixes the following sparse warning:

net/netfilter/core.c:380:6: warning:
 symbol '__nf_unregister_net_hook' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 net/netfilter/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/netfilter/core.c b/net/netfilter/core.c
index 997dd38..3f8e2d0 100644
--- a/net/netfilter/core.c
+++ b/net/netfilter/core.c
@@ -377,8 +377,8 @@ static void nf_remove_net_hook(struct nf_hook_entries *old,
 	}
 }
 
-void __nf_unregister_net_hook(struct net *net, int pf,
-			      const struct nf_hook_ops *reg)
+static void __nf_unregister_net_hook(struct net *net, int pf,
+				     const struct nf_hook_ops *reg)
 {
 	struct nf_hook_entries __rcu **pp;
 	struct nf_hook_entries *p;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] netfilter: core: make local function __nf_unregister_net_hook static
  2018-01-10  7:05 [PATCH net-next] netfilter: core: make local function __nf_unregister_net_hook static Wei Yongjun
@ 2018-01-10 13:41 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2018-01-10 13:41 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: Jozsef Kadlecsik, Florian Westphal, netfilter-devel, coreteam,
	netdev

On Wed, Jan 10, 2018 at 07:05:06AM +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
> 
> net/netfilter/core.c:380:6: warning:
>  symbol '__nf_unregister_net_hook' was not declared. Should it be static?

Also applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-10 13:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-10  7:05 [PATCH net-next] netfilter: core: make local function __nf_unregister_net_hook static Wei Yongjun
2018-01-10 13:41 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).