From: Dmitry Safonov <dima@arista.com>
To: David Miller <davem@davemloft.net>
Cc: nharold@google.com, fw@strlen.de, steffen.klassert@secunet.com,
linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au,
0x7f454c46@gmail.com, netdev@vger.kernel.org, luto@kernel.org,
ard.biesheuvel@linaro.org, hpa@zytor.com, mingo@redhat.com,
john.stultz@linaro.org, kirill.shutemov@linux.intel.com,
oleg@redhat.com, sboyd@kernel.org, rostedt@goodmis.org,
tglx@linutronix.de, x86@kernel.org, linux-efi@vger.kernel.org,
akpm@linux-foundation.org, gregkh@linuxfoundation.org,
mchehab+samsung@kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, eparis@redhat.com,
kadlec@blackhole.kfki.hu, pablo@netfilter.org,
paul@paul-moore.com, coreteam@netfilter.org,
linux-audit@redhat.com, netfilter-devel@vger.kernel.org,
fan.du@intel.com
Subject: Re: [PATCH 00/18] xfrm: Add compat layer
Date: Mon, 30 Jul 2018 18:39:20 +0100 [thread overview]
Message-ID: <1532972360.2679.32.camel@arista.com> (raw)
In-Reply-To: <20180728.141812.1026007723536955024.davem@davemloft.net>
On Sat, 2018-07-28 at 14:18 -0700, David Miller wrote:
> From: Dmitry Safonov <dima@arista.com>
> Date: Sat, 28 Jul 2018 17:26:55 +0100
>
> > Well, I think, I'll rework my patches set according to critics and
> > separate compat xfrm layer. I've already a selftest to check that
> 32/64
> > bit xfrm works - so the most time-taking part is done.
>
> The way you've done the compat structures using __packed is only
> going
> to work on x86, just FYI.
Thanks for pointing, so I'll probably cover it under something like
HAS_COMPAT_XFRM.
(if there isn't any better idea).
> The "32-bit alignment for 64-bit objects" thing x86 has is very much
> not universal amongst ABIs having 32-bit and 64-bit variants.
--
Thanks,
Dmitry
next prev parent reply other threads:[~2018-07-30 17:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 2:31 [PATCH 00/18] xfrm: Add compat layer Dmitry Safonov
2018-07-26 2:31 ` [PATCH 07/18] netlink: Pass groups pointer to .bind() Dmitry Safonov
2018-07-26 8:49 ` [PATCH 00/18] xfrm: Add compat layer Florian Westphal
2018-07-27 7:37 ` Steffen Klassert
2018-07-27 14:02 ` Dmitry Safonov
2018-07-27 14:19 ` Florian Westphal
2018-07-27 14:51 ` Dmitry Safonov
2018-07-27 16:48 ` Nathan Harold
2018-07-27 17:09 ` Andy Lutomirski
2018-07-28 16:26 ` Dmitry Safonov
2018-07-28 21:18 ` David Miller
2018-07-30 17:39 ` Dmitry Safonov [this message]
2018-07-30 19:43 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532972360.2679.32.camel@arista.com \
--to=dima@arista.com \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=fan.du@intel.com \
--cc=fw@strlen.de \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=kadlec@blackhole.kfki.hu \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-audit@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nharold@google.com \
--cc=oleg@redhat.com \
--cc=pablo@netfilter.org \
--cc=paul@paul-moore.com \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=shuah@kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).