netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] xtables-legacy: add missing config.h include
Date: Tue, 19 Mar 2019 16:16:41 +0100	[thread overview]
Message-ID: <1553008601.4806.7.camel@pengutronix.de> (raw)
In-Reply-To: <20190318154214.snghtdepv4h3e4k4@salvia>

Hi Pablo,

Am Montag, den 18.03.2019, 16:42 +0100 schrieb Pablo Neira Ayuso:
> Hi Lucas,
> 
> I can blindly take this, since I guess you're fixing a problem there.
> 
> I guess it's a compilation issue with some specific toolchain? Because
> I cannot reproduce this here.

This fixes a IPv4 only build, where this file would have references to
functions that aren't built in this case. I'm not sure how it ends up
with ENABLE_IPV6 defined without the config.h include, but since this
was clearly missing and fixed my issue, I didn't bother tracking down
the chain.

Regards,
Lucas

> Thanks!
> 
> On Fri, Mar 08, 2019 at 03:37:09PM +0100, Lucas Stach wrote:
> > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> >  iptables/xtables-legacy-multi.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/iptables/xtables-legacy-multi.c b/iptables/xtables-legacy-multi.c
> > index e68814dd082e..3b7905ff76b1 100644
> > --- a/iptables/xtables-legacy-multi.c
> > +++ b/iptables/xtables-legacy-multi.c
> > @@ -1,3 +1,4 @@
> > +#include <config.h>
> >  #include <stdio.h>
> >  #include <stdlib.h>
> >  #include <string.h>
> > -- 
> > 2.20.1
> > 

  reply	other threads:[~2019-03-19 15:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-08 14:37 [PATCH] xtables-legacy: add missing config.h include Lucas Stach
2019-03-18 15:42 ` Pablo Neira Ayuso
2019-03-19 15:16   ` Lucas Stach [this message]
2019-04-03 18:10     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1553008601.4806.7.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).