netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next 0/3] netfilter: header cleanup
@ 2019-04-15 20:43 Paul Gortmaker
  2019-04-15 20:43 ` [PATCH -next 1/3] netfilter: nf_tables: relocate header content to consumer Paul Gortmaker
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Paul Gortmaker @ 2019-04-15 20:43 UTC (permalink / raw)
  To: netdev
  Cc: Paul Gortmaker, David S. Miller, Florian Westphal,
	Jozsef Kadlecsik, Pablo Neira Ayuso, netfilter-devel, coreteam

Having core header files in include/linux that in turn include other
headers with a high number of includes implicitly degenerates into
a formalism that hides what amounts to #include <linux/everything.h>

Some headers, like module.h and device.h are good examples that will
essentially drag in almost everything.

There is nothing module specific about netfilter, but before we try
and stop nf_tables.h from including module.h, we have to fix two
instances of code which are implicitly relying on that module.h
inclusion, so as to not introduce build regressions.

---

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Florian Westphal <fw@strlen.de>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Cc: coreteam@netfilter.org

Paul Gortmaker (3):
  netfilter: nf_tables: relocate header content to consumer
  netfilter: nf_tables: fix implicit include of module.h
  netfilter: nf_tables: drop include of module.h from nf_tables.h

 include/net/netfilter/nf_tables.h  | 20 ++------------------
 net/netfilter/nf_tables_set_core.c |  1 +
 net/netfilter/nft_dynset.c         | 17 +++++++++++++++++
 3 files changed, 20 insertions(+), 18 deletions(-)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-04-30 11:39 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-15 20:43 [PATCH -next 0/3] netfilter: header cleanup Paul Gortmaker
2019-04-15 20:43 ` [PATCH -next 1/3] netfilter: nf_tables: relocate header content to consumer Paul Gortmaker
2019-04-15 20:43 ` [PATCH -next 2/3] netfilter: nf_tables: fix implicit include of module.h Paul Gortmaker
2019-04-15 20:43 ` [PATCH -next 3/3] netfilter: nf_tables: drop include of module.h from nf_tables.h Paul Gortmaker
2019-04-30 11:39 ` [PATCH -next 0/3] netfilter: header cleanup Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).