netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eugene Crosser <crosser@average.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: ebtables: load-on-demand extensions
Date: Tue, 16 Jun 2020 17:54:49 +0200	[thread overview]
Message-ID: <1566db8a-00d4-d9de-8c3d-6625fe2149fa@average.org> (raw)
In-Reply-To: <nycvar.YFH.7.77.849.2006161717590.16107@n3.vanv.qr>


[-- Attachment #1.1: Type: text/plain, Size: 1056 bytes --]

On 6/16/20 5:21 PM, Jan Engelhardt wrote:

>> 2. Is it correct that "new generation" `nft` filtering infrastructure
>> does not support dynamically loadable extensions at all? (We need a
>> custom kernel module because we need access to the fields in the skb
>> that are not exposed to `nft`, and we need a custom extension to
>> configure the custom module.)
> 
> Why not make a patch to publicly expose the skb's data via nft_meta?
> No more custom modules, no more userspace modifications, that would seem 
> to be a win-win situation.

This looks unrealistic to me, at least at the first glance. For our
particular use case, we are running the skb through the kernel function
`skb_validate_network_len()` with custom mtu size, and make decision
based on the outcome. Who knows what other things other people may need
to do. At least the kernel module seems to be a must.

OTOH if it were possible to configure the module in an "agnostic" way,
without a custom "extension" shared object, that would be a win.

Regards,

Eugene


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-06-16 15:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-16 14:48 ebtables: load-on-demand extensions Eugene Crosser
2020-06-16 15:21 ` Jan Engelhardt
2020-06-16 15:54   ` Eugene Crosser [this message]
2020-06-16 16:33     ` Jan Engelhardt
2020-06-19 13:45       ` Eugene Crosser
2020-06-19 15:15         ` Pablo Neira Ayuso
2020-06-19 16:21           ` Eugene Crosser
2020-06-20 10:34           ` Expose skb_gso_validate_network_len() [Was: ebtables: load-on-demand extensions] Eugene Crosser
2020-06-20 11:04             ` Florian Westphal
2020-06-20 21:16               ` Eugene Crosser
2020-06-21  3:24                 ` Florian Westphal
2020-06-21 10:03                   ` Jan Engelhardt
2020-06-21 18:48                     ` Eugene Crosser
2020-06-21 23:52                     ` Florian Westphal
2020-06-22  4:50                       ` Jan Engelhardt
2020-06-22  7:41                         ` Eugene Crosser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1566db8a-00d4-d9de-8c3d-6625fe2149fa@average.org \
    --to=crosser@average.org \
    --cc=jengelh@inai.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).