[PATCH net-next] docs: nf_flowtable: fix compilation and warnings

[PATCH net-next] docs: nf_flowtable: fix compilation and warnings

[Pablo Neira Ayuso]

... cannot be used in block quote, it breaks compilation, remove it.

Fix warnings due to missing blank line such as:

net-next/Documentation/networking/nf_flowtable.rst:142: WARNING: Block quote ends without a blank line; unexpected unindent.

Fixes: 143490cde566 ("docs: nf_flowtable: update documentation with enhancements")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 Documentation/networking/nf_flowtable.rst | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/networking/nf_flowtable.rst b/Documentation/networking/nf_flowtable.rst
index d87f253b9d39..d757c21c10f2 100644
--- a/Documentation/networking/nf_flowtable.rst
+++ b/Documentation/networking/nf_flowtable.rst
@@ -112,6 +112,7 @@ You can identify offloaded flows through the [OFFLOAD] tag when listing your
 connection tracking table.
 
 ::
+
 	# conntrack -L
 	tcp      6 src=10.141.10.2 dst=192.168.10.2 sport=52728 dport=5201 src=192.168.10.2 dst=192.168.10.1 sport=5201 dport=52728 [OFFLOAD] mark=0 use=2
 
@@ -138,6 +139,7 @@ allows the flowtable to define a fastpath bypass between the bridge ports
 device (represented as eth0) in your switch/router.
 
 ::
+
                       fastpath bypass
                .-------------------------.
               /                           \
@@ -168,12 +170,12 @@ connection tracking entry by specifying the counter statement in your flowtable
 definition, e.g.
 
 ::
+
 	table inet x {
 		flowtable f {
 			hook ingress priority 0; devices = { eth0, eth1 };
 			counter
 		}
-		...
 	}
 
 Counter support is available since Linux kernel 5.7.
@@ -185,12 +187,12 @@ If your network device provides hardware offload support, you can turn it on by
 means of the 'offload' flag in your flowtable definition, e.g.
 
 ::
+
 	table inet x {
 		flowtable f {
 			hook ingress priority 0; devices = { eth0, eth1 };
 			flags offload;
 		}
-		...
 	}
 
 There is a workqueue that adds the flows to the hardware. Note that a few
-- 
2.30.2

Re: [PATCH net-next] docs: nf_flowtable: fix compilation and warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2476 bytes --]

Hi Pablo,

On Thu, 25 Mar 2021 22:10:16 +0100 Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>
> ... cannot be used in block quote, it breaks compilation, remove it.
> 
> Fix warnings due to missing blank line such as:
> 
> net-next/Documentation/networking/nf_flowtable.rst:142: WARNING: Block quote ends without a blank line; unexpected unindent.
> 
> Fixes: 143490cde566 ("docs: nf_flowtable: update documentation with enhancements")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
>  Documentation/networking/nf_flowtable.rst | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/networking/nf_flowtable.rst b/Documentation/networking/nf_flowtable.rst
> index d87f253b9d39..d757c21c10f2 100644
> --- a/Documentation/networking/nf_flowtable.rst
> +++ b/Documentation/networking/nf_flowtable.rst
> @@ -112,6 +112,7 @@ You can identify offloaded flows through the [OFFLOAD] tag when listing your
>  connection tracking table.
>  
>  ::
> +
>  	# conntrack -L
>  	tcp      6 src=10.141.10.2 dst=192.168.10.2 sport=52728 dport=5201 src=192.168.10.2 dst=192.168.10.1 sport=5201 dport=52728 [OFFLOAD] mark=0 use=2
>  
> @@ -138,6 +139,7 @@ allows the flowtable to define a fastpath bypass between the bridge ports
>  device (represented as eth0) in your switch/router.
>  
>  ::
> +
>                        fastpath bypass
>                 .-------------------------.
>                /                           \
> @@ -168,12 +170,12 @@ connection tracking entry by specifying the counter statement in your flowtable
>  definition, e.g.
>  
>  ::
> +
>  	table inet x {
>  		flowtable f {
>  			hook ingress priority 0; devices = { eth0, eth1 };
>  			counter
>  		}
> -		...
>  	}
>  
>  Counter support is available since Linux kernel 5.7.
> @@ -185,12 +187,12 @@ If your network device provides hardware offload support, you can turn it on by
>  means of the 'offload' flag in your flowtable definition, e.g.
>  
>  ::
> +
>  	table inet x {
>  		flowtable f {
>  			hook ingress priority 0; devices = { eth0, eth1 };
>  			flags offload;
>  		}
> -		...
>  	}
>  
>  There is a workqueue that adds the flows to the hardware. Note that a few

Thanks.

I will add this into linux-next today and will drop it when it (or
something similar) turns up in a tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH net-next] docs: nf_flowtable: fix compilation and warnings

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 25 Mar 2021 22:10:16 +0100 you wrote:
> ... cannot be used in block quote, it breaks compilation, remove it.
> 
> Fix warnings due to missing blank line such as:
> 
> net-next/Documentation/networking/nf_flowtable.rst:142: WARNING: Block quote ends without a blank line; unexpected unindent.
> 
> Fixes: 143490cde566 ("docs: nf_flowtable: update documentation with enhancements")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> 
> [...]

Here is the summary with links:
  - [net-next] docs: nf_flowtable: fix compilation and warnings
    https://git.kernel.org/netdev/net-next/c/794d9b25817a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html