netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
	netdev@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH net 1/3] netfilter: nf_tables: initialize set before expression setup
Date: Thu, 10 Jun 2021 21:50:05 +0000	[thread overview]
Message-ID: <162336180590.29138.15815701768531267437.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210610165458.23071-2-pablo@netfilter.org>

Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Thu, 10 Jun 2021 18:54:56 +0200 you wrote:
> nft_set_elem_expr_alloc() needs an initialized set if expression sets on
> the NFT_EXPR_GC flag. Move set fields initialization before expression
> setup.
> 
> [4512935.019450] ==================================================================
> [4512935.019456] BUG: KASAN: null-ptr-deref in nft_set_elem_expr_alloc+0x84/0xd0 [nf_tables]
> [4512935.019487] Read of size 8 at addr 0000000000000070 by task nft/23532
> [4512935.019494] CPU: 1 PID: 23532 Comm: nft Not tainted 5.12.0-rc4+ #48
> [...]
> [4512935.019502] Call Trace:
> [4512935.019505]  dump_stack+0x89/0xb4
> [4512935.019512]  ? nft_set_elem_expr_alloc+0x84/0xd0 [nf_tables]
> [4512935.019536]  ? nft_set_elem_expr_alloc+0x84/0xd0 [nf_tables]
> [4512935.019560]  kasan_report.cold.12+0x5f/0xd8
> [4512935.019566]  ? nft_set_elem_expr_alloc+0x84/0xd0 [nf_tables]
> [4512935.019590]  nft_set_elem_expr_alloc+0x84/0xd0 [nf_tables]
> [4512935.019615]  nf_tables_newset+0xc7f/0x1460 [nf_tables]
> 
> [...]

Here is the summary with links:
  - [net,1/3] netfilter: nf_tables: initialize set before expression setup
    https://git.kernel.org/netdev/net/c/ad9f151e560b
  - [net,2/3] selftests: netfilter: add fib test case
    https://git.kernel.org/netdev/net/c/82944421243e
  - [net,3/3] netfilter: nft_fib_ipv6: skip ipv6 packets from any to link-local
    https://git.kernel.org/netdev/net/c/12f36e9bf678

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



  reply	other threads:[~2021-06-10 21:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10 16:54 [PATCH net 0/3] Netfilter fixes for net Pablo Neira Ayuso
2021-06-10 16:54 ` [PATCH net 1/3] netfilter: nf_tables: initialize set before expression setup Pablo Neira Ayuso
2021-06-10 21:50   ` patchwork-bot+netdevbpf [this message]
2021-06-10 16:54 ` [PATCH net 2/3] selftests: netfilter: add fib test case Pablo Neira Ayuso
2021-06-10 16:54 ` [PATCH net 3/3] netfilter: nft_fib_ipv6: skip ipv6 packets from any to link-local Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=162336180590.29138.15815701768531267437.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).