netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Jarosch <thomas.jarosch@intra2net.com>
To: netfilter-devel@vger.kernel.org
Cc: Jan Engelhardt <jengelh@inai.de>
Subject: Re: [PATCH 2/5] include: use C++ headers in C++ mode
Date: Fri, 07 Jun 2013 10:35:01 +0200	[thread overview]
Message-ID: <1648235.41SkZRnnpI@storm> (raw)
In-Reply-To: <1289430485-16467-3-git-send-email-jengelh@medozas.de>

Hi Jan,

On Thursday, 11. November 2010 00:08:01 you wrote:
> Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
> ---
>  include/libmnl/libmnl.h |   13 ++++++++-----
>  1 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/include/libmnl/libmnl.h b/include/libmnl/libmnl.h
> index 7094af2..37c502a 100644
> --- a/include/libmnl/libmnl.h
> +++ b/include/libmnl/libmnl.h
> @@ -1,13 +1,16 @@
>  #ifndef _LIBMNL_H_
>  #define _LIBMNL_H_
> 
> -#include <stdio.h>
> -#include <stdint.h>
> +#ifdef __cplusplus
> +#	include <cstdio>
> +#	include <cstdint>
> +#else
> +#	include <stdbool.h> /* not in C++ */
> +#	include <stdio.h>
> +#	include <stdint.h>
> +#endif

just a side note regarding this old commit:

The header "<cstdint>" is part of the C++11 standard.
(http://www.cplusplus.com/reference/cstdint/)

g++ forces you to enable C++11 mode if you want to use it.
Tested with g++ (GCC) 4.4.4.

Do we really need this? It compiles fine without
the special headers inside the __cplusplus part.
Pablo asked the same back in 2010 ;)

Best regards,
Thomas


  parent reply	other threads:[~2013-06-07  8:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-10 23:07 libmnl misc patches Nov 11 Jan Engelhardt
2010-11-10 23:08 ` [PATCH 1/5] socket: constify a struct sockaddr_nl Jan Engelhardt
2010-11-11 12:56   ` Pablo Neira Ayuso
2010-11-10 23:08 ` [PATCH 2/5] include: use C++ headers in C++ mode Jan Engelhardt
2010-11-11 12:57   ` Pablo Neira Ayuso
2010-11-11 12:59     ` Jan Engelhardt
2010-11-11 13:15       ` Pablo Neira Ayuso
2010-11-13 18:19         ` Jan Engelhardt
2010-11-16 10:04           ` Pablo Neira Ayuso
2013-06-07  8:35   ` Thomas Jarosch [this message]
2013-06-08 13:38     ` Jan Engelhardt
2010-11-10 23:08 ` [PATCH 3/5] nlmsg: use bool for all _ok functions Jan Engelhardt
2010-11-11 12:59   ` Pablo Neira Ayuso
2010-11-10 23:08 ` [PATCH 4/5] attr: remove redundant check for NULL Jan Engelhardt
2010-11-11 13:02   ` Pablo Neira Ayuso
2010-11-10 23:08 ` [PATCH 5/5] attr: avoid multiple definition of hidden variable Jan Engelhardt
2010-11-11 13:08   ` Pablo Neira Ayuso
2010-11-11 13:25     ` Jan Engelhardt
2010-11-11 17:47       ` Pablo Neira Ayuso
2010-11-11 20:53         ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1648235.41SkZRnnpI@storm \
    --to=thomas.jarosch@intra2net.com \
    --cc=jengelh@inai.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).