* [iptables PATCH] extensions/libxt_tcp: fix nftables translate flags value, 'none' vs '0x0'
@ 2016-04-06 12:10 Arturo Borrero Gonzalez
2016-04-06 13:54 ` Vadim A. Misbakh-Soloviov
2016-04-07 9:47 ` Pablo Neira Ayuso
0 siblings, 2 replies; 3+ messages in thread
From: Arturo Borrero Gonzalez @ 2016-04-06 12:10 UTC (permalink / raw)
To: netfilter-devel; +Cc: netfilter
The iptables command:
-m tcp --tcp-flags FIN,SYN,RST,PSH,ACK,URG NONE
should translate to:
tcp flags & fin|syn|rst|psh|ack|urg == 0x0
instead of:
tcp flags & fin|syn|rst|psh|ack|urg == none
Reported-by: Vadim A. Misbakh-Soloviov <netfilter@mva.name>
Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
extensions/libxt_tcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/extensions/libxt_tcp.c b/extensions/libxt_tcp.c
index 6a85ed4..2a14035 100644
--- a/extensions/libxt_tcp.c
+++ b/extensions/libxt_tcp.c
@@ -390,7 +390,7 @@ static void print_tcp_xlate(struct xt_xlate *xl, uint8_t flags)
}
if (!have_flag)
- xt_xlate_add(xl, "none");
+ xt_xlate_add(xl, "0x0");
}
static int tcp_xlate(const void *ip, const struct xt_entry_match *match,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [iptables PATCH] extensions/libxt_tcp: fix nftables translate flags value, 'none' vs '0x0'
2016-04-06 12:10 [iptables PATCH] extensions/libxt_tcp: fix nftables translate flags value, 'none' vs '0x0' Arturo Borrero Gonzalez
@ 2016-04-06 13:54 ` Vadim A. Misbakh-Soloviov
2016-04-07 9:47 ` Pablo Neira Ayuso
1 sibling, 0 replies; 3+ messages in thread
From: Vadim A. Misbakh-Soloviov @ 2016-04-06 13:54 UTC (permalink / raw)
To: netfilter-devel; +Cc: Arturo Borrero Gonzalez
[-- Attachment #1: Type: text/plain, Size: 101 bytes --]
Tested-by: Vadim A. Misbakh-Soloviov <netfilter@mva.name>
--
// now it generates valid nftables rule
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [iptables PATCH] extensions/libxt_tcp: fix nftables translate flags value, 'none' vs '0x0'
2016-04-06 12:10 [iptables PATCH] extensions/libxt_tcp: fix nftables translate flags value, 'none' vs '0x0' Arturo Borrero Gonzalez
2016-04-06 13:54 ` Vadim A. Misbakh-Soloviov
@ 2016-04-07 9:47 ` Pablo Neira Ayuso
1 sibling, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2016-04-07 9:47 UTC (permalink / raw)
To: Arturo Borrero Gonzalez; +Cc: netfilter-devel, netfilter
On Wed, Apr 06, 2016 at 02:10:52PM +0200, Arturo Borrero Gonzalez wrote:
> The iptables command:
> -m tcp --tcp-flags FIN,SYN,RST,PSH,ACK,URG NONE
>
> should translate to:
> tcp flags & fin|syn|rst|psh|ack|urg == 0x0
>
> instead of:
> tcp flags & fin|syn|rst|psh|ack|urg == none
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-07 9:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-06 12:10 [iptables PATCH] extensions/libxt_tcp: fix nftables translate flags value, 'none' vs '0x0' Arturo Borrero Gonzalez
2016-04-06 13:54 ` Vadim A. Misbakh-Soloviov
2016-04-07 9:47 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).