* [PATCH net-next] selftests: netfilter: fix packetdrill conntrack testcase
@ 2024-05-14 14:44 Florian Westphal
2024-05-14 18:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Florian Westphal @ 2024-05-14 14:44 UTC (permalink / raw)
To: netdev; +Cc: Jakub Kicinski, Pablo Neira Ayuso, netfilter-devel,
Florian Westphal
Some versions of conntrack(8) default to ipv4-only, so this needs to request
ipv6 explicitly, like all other spots already do.
Fixes: a8a388c2aae4 ("selftests: netfilter: add packetdrill based conntrack tests")
Reported-by: Jakub Kicinski <kuba@kernel.org>
Closes: https://lore.kernel.org/netdev/20240513114649.6d764307@kernel.org/
Signed-off-by: Florian Westphal <fw@strlen.de>
---
Can't target net because ATM Fixes-commit is only in net-next.
.../net/netfilter/packetdrill/conntrack_synack_reuse.pkt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/netfilter/packetdrill/conntrack_synack_reuse.pkt b/tools/testing/selftests/net/netfilter/packetdrill/conntrack_synack_reuse.pkt
index 21e1bb6395e4..842242f8ccf7 100644
--- a/tools/testing/selftests/net/netfilter/packetdrill/conntrack_synack_reuse.pkt
+++ b/tools/testing/selftests/net/netfilter/packetdrill/conntrack_synack_reuse.pkt
@@ -30,5 +30,5 @@
1.5 < S 2000:2000(0) win 32792 <mss 1000,nop,wscale 0, TS val 233 ecr 0,nop,nop>
-+0 `conntrack -L -p tcp --dport 8080 2>/dev/null | grep -q SYN_RECV`
++0 `conntrack -f $NFCT_IP_VERSION -L -p tcp --dport 8080 2>/dev/null | grep -q SYN_RECV`
+0 `iptables -v -S INPUT | grep INVALID | grep -q -- "-c 0 0"`
--
2.43.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] selftests: netfilter: fix packetdrill conntrack testcase
2024-05-14 14:44 [PATCH net-next] selftests: netfilter: fix packetdrill conntrack testcase Florian Westphal
@ 2024-05-14 18:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-05-14 18:00 UTC (permalink / raw)
To: Florian Westphal; +Cc: netdev, kuba, pablo, netfilter-devel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 14 May 2024 16:44:09 +0200 you wrote:
> Some versions of conntrack(8) default to ipv4-only, so this needs to request
> ipv6 explicitly, like all other spots already do.
>
> Fixes: a8a388c2aae4 ("selftests: netfilter: add packetdrill based conntrack tests")
> Reported-by: Jakub Kicinski <kuba@kernel.org>
> Closes: https://lore.kernel.org/netdev/20240513114649.6d764307@kernel.org/
> Signed-off-by: Florian Westphal <fw@strlen.de>
>
> [...]
Here is the summary with links:
- [net-next] selftests: netfilter: fix packetdrill conntrack testcase
https://git.kernel.org/netdev/net-next/c/dc9dfd8ae4b5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-14 18:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-14 14:44 [PATCH net-next] selftests: netfilter: fix packetdrill conntrack testcase Florian Westphal
2024-05-14 18:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).