From: Paolo Abeni <pabeni@redhat.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org,
edumazet@google.com
Subject: Re: [PATCH net 3/3] netfilter: nf_tables: Fix a memory leak in nf_tables_updchain
Date: Thu, 21 Mar 2024 11:52:29 +0100 [thread overview]
Message-ID: <1c84b33599ba6d10680162a43ea729f7353327b3.camel@redhat.com> (raw)
In-Reply-To: <20240321000635.31865-4-pablo@netfilter.org>
On Thu, 2024-03-21 at 01:06 +0100, Pablo Neira Ayuso wrote:
> From: Quan Tian <tianquan23@gmail.com>
>
> If nft_netdev_register_hooks() fails, the memory associated with
> nft_stats is not freed, causing a memory leak.
>
> This patch fixes it by moving nft_stats_alloc() down after
> nft_netdev_register_hooks() succeeds.
>
> Fixes: b9703ed44ffb ("netfilter: nf_tables: support for adding new devices to an existing netdev chain")
> Signed-off-by: Quan Tian <tianquan23@gmail.com>
I'm sorry for nit-picking, but our tag verification scripts are unhappy
WRT this commit, it lacks your SoB. Would you mind sending an updated
PR?
Thanks!
Paolo
next prev parent reply other threads:[~2024-03-21 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 0:06 [PATCH net 0/3] Netfilter fixes for net Pablo Neira Ayuso
2024-03-21 0:06 ` [PATCH net 1/3] netfilter: nft_set_pipapo: release elements in clone only from destroy path Pablo Neira Ayuso
2024-03-21 0:06 ` [PATCH net 2/3] netfilter: nf_tables: do not compare internal table flags on updates Pablo Neira Ayuso
2024-03-21 0:06 ` [PATCH net 3/3] netfilter: nf_tables: Fix a memory leak in nf_tables_updchain Pablo Neira Ayuso
2024-03-21 10:52 ` Paolo Abeni [this message]
2024-03-21 11:11 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2024-03-21 11:21 [PATCH net 0/3,v2] Netfilter fixes for net Pablo Neira Ayuso
2024-03-21 11:21 ` [PATCH net 3/3] netfilter: nf_tables: Fix a memory leak in nf_tables_updchain Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c84b33599ba6d10680162a43ea729f7353327b3.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).