From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [NETFILTER 01/03]: xt_connbytes: fix division by zero
Date: Tue, 30 Jan 2007 14:24:37 -0800 (PST) [thread overview]
Message-ID: <20070130.142437.45515562.davem@davemloft.net> (raw)
In-Reply-To: <20070130181627.25041.43611.sendpatchset@localhost.localdomain>
From: Patrick McHardy <kaber@trash.net>
Date: Tue, 30 Jan 2007 19:16:28 +0100 (MET)
> [NETFILTER]: xt_connbytes: fix division by zero
>
> When the packet counter of a connection is zero a division by zero
> occurs in div64_64(). Fix that by using zero as average value, which
> is correct as long as the packet counter didn't overflow, at which
> point we have lost anyway.
>
> Additionally we're probably going to go back to 64 bit counters
> in 2.6.21.
>
> Based on patch from Jonas Berlin <xkr47@outerspace.dyndns.org>,
> with suggestions from KOVACS Krisztian <hidden@balabit.hu>.
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Applied.
next prev parent reply other threads:[~2007-01-30 22:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 18:16 [NETFILTER 00/03]: Netfilter fixes Patrick McHardy
2007-01-30 18:16 ` [NETFILTER 01/03]: xt_connbytes: fix division by zero Patrick McHardy
2007-01-30 22:24 ` David Miller [this message]
2007-01-30 18:16 ` [NETFILTER 02/03]: SIP conntrack: fix skipping over user info in SIP headers Patrick McHardy
2007-01-30 22:25 ` David Miller
2007-01-30 18:16 ` [NETFILTER 03/03]: SIP conntrack: fix out of bounds memory access Patrick McHardy
2007-01-30 22:25 ` David Miller
2007-01-30 22:25 ` [NETFILTER 00/03]: Netfilter fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070130.142437.45515562.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).