netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: davem@davemloft.net
Cc: netfilter-devel@lists.netfilter.org, Patrick McHardy <kaber@trash.net>
Subject: [NETFILTER 07/10]: nfnetlink_log: fix possible NULL pointer dereference
Date: Sun,  4 Mar 2007 21:20:07 +0100 (MET)	[thread overview]
Message-ID: <20070304201915.28582.66793.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20070304201906.28582.51903.sendpatchset@localhost.localdomain>

[NETFILTER]: nfnetlink_log: fix possible NULL pointer dereference

Eliminate possible NULL pointer dereference in nfulnl_recv_config().

Signed-off-by: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
Signed-off-by: Patrick McHardy <kaber@trash.net>

---
commit 79fb63ea8565212c9e8fde1e18a5598b438ced08
tree 5e0e1dd8d4b2bc6af902fbd508c05bde37df98a4
parent eff0bb8715bfc8b8c2cbd58504433d3fd48b36c8
author Michal Miroslaw <mirq-linux@rere.qmqm.pl> Fri, 02 Mar 2007 13:11:38 +0100
committer Patrick McHardy <kaber@trash.net> Fri, 02 Mar 2007 13:11:38 +0100

 net/netfilter/nfnetlink_log.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
index 1b94051..b669db5 100644
--- a/net/netfilter/nfnetlink_log.c
+++ b/net/netfilter/nfnetlink_log.c
@@ -858,6 +858,9 @@ nfulnl_recv_config(struct sock *ctnl, st
 			ret = -EINVAL;
 			break;
 		}
+
+		if (!inst)
+			goto out;
 	} else {
 		if (!inst) {
 			UDEBUG("no config command, and no instance for "
@@ -911,6 +914,7 @@ nfulnl_recv_config(struct sock *ctnl, st
 
 out_put:
 	instance_put(inst);
+out:
 	return ret;
 }
 

  parent reply	other threads:[~2007-03-04 20:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-04 20:19 [NETFILTER 00/10]: Netfilter fixes Patrick McHardy
2007-03-04 20:19 ` [NETFILTER 01/10]: conntrack: fix {nf, ip}_ct_iterate_cleanup endless loops Patrick McHardy
2007-03-04 20:20 ` [NETFILTER 02/10]: nf_conntrack/nf_nat: fix incorrect config ifdefs Patrick McHardy
2007-03-04 20:20 ` [NETFILTER 03/10]: tcp conntrack: accept SYN|URG as valid Patrick McHardy
2007-03-04 20:20 ` [NETFILTER 04/10]: nfnetlink_log: fix reference leak Patrick McHardy
2007-03-04 20:20 ` [NETFILTER 05/10]: nfnetlink_log: fix use after free Patrick McHardy
2007-03-04 20:20 ` [NETFILTER 06/10]: nfnetlink_log: fix NULL pointer dereference Patrick McHardy
2007-03-04 20:20 ` Patrick McHardy [this message]
2007-03-04 20:20 ` [NETFILTER 08/10]: nfnetlink_log: fix module reference counting Patrick McHardy
2007-03-04 20:20 ` [NETFILTER 09/10]: nfnetlink_log: fix " Patrick McHardy
2007-03-04 20:20 ` [NETFILTER 10/10]: ip6_route_me_harder should take into account mark Patrick McHardy
2007-03-05  0:00 ` [NETFILTER 00/10]: Netfilter fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070304201915.28582.66793.sendpatchset@localhost.localdomain \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).