From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [NETFILTER 01/03]: nf_conntrack: fix helper module unload races
Date: Tue, 05 Jun 2007 12:55:42 -0700 (PDT) [thread overview]
Message-ID: <20070605.125542.94888173.davem@davemloft.net> (raw)
In-Reply-To: <20070605133509.10309.45032.sendpatchset@localhost.localdomain>
From: Patrick McHardy <kaber@trash.net>
Date: Tue, 5 Jun 2007 15:35:10 +0200 (MEST)
> [NETFILTER]: nf_conntrack: fix helper module unload races
>
> When a helper module is unloaded all conntracks refering to it have their
> helper pointer NULLed out, leading to lots of races. In most places this
> can be fixed by proper use of RCU (they do already check for != NULL,
> but in a racy way), additionally nf_conntrack_expect_related needs to
> bail out when no helper is present.
>
> Also remove two paranoid BUG_ONs in nf_conntrack_proto_gre that are racy
> and not worth fixing.
>
> Signed-off-by: Patrick McHarrdy <kaber@trash.net>
Applied.
next prev parent reply other threads:[~2007-06-05 19:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 13:35 [NETFILTER 00/03]: Netfilter fixes Patrick McHardy
2007-06-05 13:35 ` [NETFILTER 01/03]: nf_conntrack: fix helper module unload races Patrick McHardy
2007-06-05 19:55 ` David Miller [this message]
2007-06-09 10:41 ` Yasuyuki KOZAKAI
[not found] ` <200706091041.l59AfVck028409@toshiba.co.jp>
2007-06-18 12:29 ` Patrick McHardy
2007-06-20 10:57 ` [NETFILTER]: nfctnetlink: Don't allow to change helper (Was: Re: [NETFILTER 01/03]: nf_conntrack: fix helper module unload races) Yasuyuki KOZAKAI
2007-06-05 13:35 ` [NETFILTER 02/03]: ip_tables: fix compat related crash Patrick McHardy
2007-06-05 19:56 ` David Miller
2007-06-05 13:35 ` [NETFILTER 03/03]: nf_conntrack_amanda: fix textsearch_prepare() error check Patrick McHardy
2007-06-05 19:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070605.125542.94888173.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).