From: Thomas Graf <tgraf@suug.ch>
To: Philip Craig <philipc@snapgear.com>
Cc: Netfilter Developer Mailing List <netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH 1/3] libnl: add netfilter support
Date: Mon, 3 Sep 2007 12:09:43 +0200 [thread overview]
Message-ID: <20070903100943.GH18480@postel.suug.ch> (raw)
In-Reply-To: <46DB9776.8020209@snapgear.com>
* Philip Craig <philipc@snapgear.com> 2007-09-03 15:11
> Index: libnl/lib/attr.c
> ===================================================================
> --- libnl.orig/lib/attr.c 2007-09-03 14:24:29.000000000 +1000
> +++ libnl/lib/attr.c 2007-09-03 14:24:45.000000000 +1000
> @@ -261,7 +261,8 @@ int nla_parse(struct nlattr *tb[], int m
> memset(tb, 0, sizeof(struct nlattr *) * (maxtype + 1));
>
> nla_for_each_attr(nla, head, len, rem) {
> - uint16_t type = nla->nla_type;
> + /* Ignore NFNL_NFA_NEST bit, hope nothing else uses it */
> + uint16_t type = nla->nla_type & 0x7fff;
I wonder if it is useful to make this behaviour conditional so that
the netfilter subsystem could enable this for backwards compatibility
while other subsystems won't be affected.
It will offend a few people but it's still pre 1.0 and we can break
the API. I'd rather get this right now than having to life with
side effects for a long time.
next prev parent reply other threads:[~2007-09-03 10:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-03 5:09 netfilter support in libnl Philip Craig
2007-09-03 5:11 ` [PATCH 1/3] libnl: add netfilter support Philip Craig
2007-09-03 9:50 ` Patrick McHardy
2007-09-03 10:01 ` Thomas Graf
2007-09-03 10:06 ` Patrick McHardy
2007-09-03 10:15 ` Thomas Graf
2007-09-03 10:53 ` Patrick McHardy
2007-09-03 11:03 ` Thomas Graf
2007-09-03 11:13 ` Patrick McHardy
2007-09-04 1:18 ` Philip Craig
2007-09-03 10:09 ` Thomas Graf [this message]
2007-09-04 2:12 ` Philip Craig
2007-09-04 9:39 ` Thomas Graf
2007-09-04 11:36 ` Thomas Graf
2007-09-03 5:11 ` [PATCH 2/3] libnl: add netfilter conntrack support Philip Craig
2007-09-04 16:45 ` Thomas Graf
2007-09-03 5:12 ` [PATCH 3/3] libnl: add netfilter log support Philip Craig
2007-09-04 16:48 ` Thomas Graf
2007-09-03 9:30 ` netfilter support in libnl Patrick McHardy
2007-09-03 9:59 ` Thomas Graf
2007-09-03 10:05 ` Patrick McHardy
2007-09-03 10:16 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070903100943.GH18480@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=netfilter-devel@lists.netfilter.org \
--cc=philipc@snapgear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).