From: David Miller <davem@davemloft.net>
To: ole@ans.pl
Cc: kaber@trash.net, netfilter-devel@vger.kernel.org
Subject: Re: [NETFILTER 01/02]: nf_conntrack_tcp: fix connection reopening fix
Date: Thu, 18 Oct 2007 05:12:52 -0700 (PDT) [thread overview]
Message-ID: <20071018.051252.71873220.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0710181231210.17074@bizon.gios.gov.pl>
From: Krzysztof Oledzki <ole@ans.pl>
Date: Thu, 18 Oct 2007 12:37:42 +0200 (CEST)
>
>
> On Thu, 18 Oct 2007, Patrick McHardy wrote:
>
> > Krzysztof Oledzki wrote:
> >>
> >>
> >> On Thu, 18 Oct 2007, Patrick McHardy wrote:
> >>
> >>> [NETFILTER]: nf_conntrack_tcp: fix connection reopening fix
> >>>
> >>> Setting the last_dir parameter was missing from the previous one.
> >>
> >> This description is IMHO wrong. It should be as in previous, little
> >> incomplete (last_dir), patch:
> >>
> >> "If one side aborts an established connection, the entry still lingers for
> >> 10s in conntrack for the late packets. Allow to open up the connection
> >> again for the party which sent the RST packet."
> >
> >
> > The first patch was submitted seperately with a somewhat similar
> > description. This is just the incremental fix.
>
> No, there are two independent fixes. The first one is already in the
> mainline (nf_conntrack_tcp: fix connection reopening) and it is OK:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=17311393f969090ab060540bd9dbe7dc885a76d5
>
> The second one had been incomplete:
> http://marc.info/?l=netfilter-devel&m=119214261727254&w=1
> and it was recently fixed:
> http://marc.info/?l=netfilter-devel&m=119264302103523&w=1
>
> So, this "Setting the last_dir parameter was missing from the previous
> one." comment applies to this patch:
> http://marc.info/?l=netfilter-devel&m=119214261727254&w=1
Please sort out this changelog message issue so I can apply
the patch correctly :-)
Thanks!
next prev parent reply other threads:[~2007-10-18 12:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 10:12 [NETFILTER 00/02]: Netfilter fixes Patrick McHardy
2007-10-18 10:12 ` [NETFILTER 01/02]: nf_conntrack_tcp: fix connection reopening fix Patrick McHardy
2007-10-18 10:26 ` Krzysztof Oledzki
2007-10-18 10:29 ` Patrick McHardy
2007-10-18 10:37 ` Krzysztof Oledzki
2007-10-18 12:12 ` David Miller [this message]
2007-10-18 12:16 ` Patrick McHardy
2007-10-18 12:22 ` David Miller
2007-10-18 13:21 ` Jozsef Kadlecsik
2007-10-18 10:12 ` [NETFILTER 02/02]: xt_sctp: fix mistake to pass a pointer where array is required Patrick McHardy
2007-10-18 12:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071018.051252.71873220.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=ole@ans.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).