netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Victor Stinner <victor.stinner@inl.fr>
To: netfilter-devel@vger.kernel.org
Subject: libnetfilter_conntrack broken on PPC
Date: Fri, 16 Nov 2007 11:39:19 +0100	[thread overview]
Message-ID: <200711161139.19580.victor.stinner@inl.fr> (raw)

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

Hi,

Libnetfilter_conntrack doesn't work on PPC because a small bug in "getters" 
(8, 16, 32 bits). The problem only occurs on big endian architecture and is 
already fixed in subversion. My patch only fix big endian bug, and is very 
small ;-)

I sent the patch to Pablo Neira Ayuso the first october, but he looks very 
busy. Can someone else release a new version of libnetfilter_conntrack? If 
nobody cares, can I get the status of new libnetfilter_conntrack maintainer?

Victor Stinner
http://www.inl.fr/

[-- Attachment #2: api.patch --]
[-- Type: text/x-diff, Size: 948 bytes --]

--- libnetfilter_conntrack-0.0.81/src/conntrack/api.c	2007-06-25 20:40:03.000000000 +0200
+++ libnetfilter_conntrack-trunk/src/conntrack/api.c	2007-09-02 12:02:28.000000000 +0200
@@ -304,7 +304,7 @@
 u_int8_t nfct_get_attr_u8(const struct nf_conntrack *ct,
 			  const enum nf_conntrack_attr type)
 {
-	const int *ret = nfct_get_attr(ct, type);
+	const u_int8_t *ret = nfct_get_attr(ct, type);
 	return ret == NULL ? 0 : *ret;
 }
 
@@ -320,7 +320,7 @@
 u_int16_t nfct_get_attr_u16(const struct nf_conntrack *ct,
 			    const enum nf_conntrack_attr type)
 {
-	const int *ret = nfct_get_attr(ct, type);
+	const u_int16_t *ret = nfct_get_attr(ct, type);
 	return ret == NULL ? 0 : *ret;
 }
 
@@ -336,7 +336,7 @@
 u_int32_t nfct_get_attr_u32(const struct nf_conntrack *ct,
 			    const enum nf_conntrack_attr type)
 {
-	const int *ret = nfct_get_attr(ct, type);
+	const u_int32_t *ret = nfct_get_attr(ct, type);
 	return ret == NULL ? 0 : *ret;
 }
 

             reply	other threads:[~2007-11-16 10:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-16 10:39 Victor Stinner [this message]
2007-11-16 12:30 ` libnetfilter_conntrack broken on PPC Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711161139.19580.victor.stinner@inl.fr \
    --to=victor.stinner@inl.fr \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).