From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [NETFILTER]: bridge: fix missing link layer headers on outgoing routed packets
Date: Thu, 13 Dec 2007 09:32:46 -0800 (PST) [thread overview]
Message-ID: <20071213.093246.83297959.davem@davemloft.net> (raw)
In-Reply-To: <47616BC6.9010208@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Thu, 13 Dec 2007 18:28:38 +0100
> [NETFILTER]: bridge: fix missing link layer headers on outgoing routed packets
>
> As reported by Damien Thebault, the double POSTROUTING hook invocation
> fix caused outgoing packets routed between two bridges to appear without
> a link-layer header. The reason for this is that we're skipping the
> br_nf_post_routing hook for routed packets now and don't save the
> original link layer header, but nevertheless tries to restore it on
> output, causing corruption.
>
> The root cause for this is that skb->nf_bridge has no clearly defined
> lifetime and is used to indicate all kind of things, but that is
> quite complicated to fix. For now simply don't touch these packets
> and handle them like packets from any other device.
>
> Tested-by: Damien Thebault <damien.thebault@gmail.com>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Applied to net-2.6, thanks Patrick.
prev parent reply other threads:[~2007-12-13 17:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 17:28 [NETFILTER]: bridge: fix missing link layer headers on outgoing routed packets Patrick McHardy
2007-12-13 17:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213.093246.83297959.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).