netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: [PATCH 7/8] netfilter: more spase fixes
Date: Thu, 24 Jan 2008 10:15:43 -0800	[thread overview]
Message-ID: <20080124181628.468442092@vyatta.com> (raw)
In-Reply-To: 20080124181536.446214111@vyatta.com

[-- Attachment #1: nf-yms.patch --]
[-- Type: text/plain, Size: 1321 bytes --]

Some lock annotations, and make initializers static.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>


--- a/net/netfilter/xt_hashlimit.c	2008-01-24 10:10:46.000000000 -0800
+++ b/net/netfilter/xt_hashlimit.c	2008-01-24 10:12:30.000000000 -0800
@@ -624,6 +624,7 @@ static struct xt_match hashlimit_mt_reg[
 
 /* PROC stuff */
 static void *dl_seq_start(struct seq_file *s, loff_t *pos)
+	__acquires(htable->lock)
 {
 	struct proc_dir_entry *pde = s->private;
 	struct xt_hashlimit_htable *htable = pde->data;
@@ -656,6 +657,7 @@ static void *dl_seq_next(struct seq_file
 }
 
 static void dl_seq_stop(struct seq_file *s, void *v)
+	__releases(htable->lock)
 {
 	struct proc_dir_entry *pde = s->private;
 	struct xt_hashlimit_htable *htable = pde->data;
--- a/net/ipv4/netfilter/nf_nat_proto_gre.c	2008-01-24 10:10:46.000000000 -0800
+++ b/net/ipv4/netfilter/nf_nat_proto_gre.c	2008-01-24 10:12:30.000000000 -0800
@@ -148,12 +148,12 @@ static const struct nf_nat_protocol gre 
 #endif
 };
 
-int __init nf_nat_proto_gre_init(void)
+static int __init nf_nat_proto_gre_init(void)
 {
 	return nf_nat_protocol_register(&gre);
 }
 
-void __exit nf_nat_proto_gre_fini(void)
+static void __exit nf_nat_proto_gre_fini(void)
 {
 	nf_nat_protocol_unregister(&gre);
 }

-- 
Stephen Hemminger <stephen.hemminger@vyatta.com>


  parent reply	other threads:[~2008-01-24 18:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-24 18:15 [PATCH 0/8] trivial patches to netfilter for net-2.6.25 Stephen Hemminger
2008-01-24 18:15 ` [PATCH 1/8] nf_nat_snmp: sparse warning Stephen Hemminger
2008-01-24 18:32   ` Patrick McHardy
2008-01-24 18:15 ` [PATCH 2/8] netfilter: get rid of " Stephen Hemminger
2008-01-24 18:34   ` Patrick McHardy
2008-01-24 18:15 ` [PATCH 3/8] nf_conntrack: sparse warnings Stephen Hemminger
2008-01-24 18:35   ` Patrick McHardy
2008-01-24 18:15 ` [PATCH 4/8] netfilter: more sparse warning fixes Stephen Hemminger
2008-01-24 18:40   ` Patrick McHardy
2008-01-24 18:15 ` [PATCH 5/8] conntrack: get rid of sparse warnings Stephen Hemminger
2008-01-24 18:42   ` Patrick McHardy
2008-01-24 18:15 ` [PATCH 6/8] nf_conntrack-h323: sparse fixes Stephen Hemminger
2008-01-24 18:44   ` Patrick McHardy
2008-01-24 18:15 ` Stephen Hemminger [this message]
2008-01-24 18:43   ` [PATCH 7/8] netfilter: more spase fixes Patrick McHardy
2008-01-24 18:15 ` [PATCH 8/8] nf_conntrack ipv6: unused code and sparse fix Stephen Hemminger
2008-01-24 18:45   ` Patrick McHardy
2008-01-25  1:24     ` Yasuyuki KOZAKAI
2008-01-28  2:50       ` Yasuyuki KOZAKAI
     [not found]       ` <200801280250.m0S2oWF1019241@toshiba.co.jp>
2008-01-29 12:54         ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080124181628.468442092@vyatta.com \
    --to=shemminger@vyatta.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).