From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [NETFILTER 01/05]: nf_conntrack: fix smp_processor_id() in preemptible code warning
Date: Wed, 27 Feb 2008 12:09:15 -0800 (PST) [thread overview]
Message-ID: <20080227.120915.54901797.davem@davemloft.net> (raw)
In-Reply-To: <20080227131428.26831.70102.sendpatchset@localhost.localdomain>
From: Patrick McHardy <kaber@trash.net>
Date: Wed, 27 Feb 2008 14:14:20 +0100 (MET)
> [NETFILTER]: nf_conntrack: fix smp_processor_id() in preemptible code warning
>
> Since we're using RCU for the conntrack hash now, we need to avoid
> getting preempted or interrupted by BHs while changing the stats.
>
> Fixes warning reported by Tilman Schmidt <tilman@imap.cc> when using
> preemptible RCU:
>
> [ 48.180297] BUG: using smp_processor_id() in preemptible [00000000] code: ntpdate/3562
> [ 48.180297] caller is __nf_conntrack_find+0x9b/0xeb [nf_conntrack]
> [ 48.180297] Pid: 3562, comm: ntpdate Not tainted 2.6.25-rc2-mm1-testing #1
> [ 48.180297] [<c02015b9>] debug_smp_processor_id+0x99/0xb0
> [ 48.180297] [<fac643a7>] __nf_conntrack_find+0x9b/0xeb [nf_conntrack]
>
> Tested-by: Tilman Schmidt <tilman@imap.cc>
> Tested-by: Christian Casteyde <casteyde.christian@free.fr> [Bugzilla #10097]
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Applied.
next prev parent reply other threads:[~2008-02-27 20:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 13:14 [NETFILTER 00/05]: Netfilter fixes Patrick McHardy
2008-02-27 13:14 ` [NETFILTER 01/05]: nf_conntrack: fix smp_processor_id() in preemptible code warning Patrick McHardy
2008-02-27 20:09 ` David Miller [this message]
2008-02-27 13:14 ` [NETFILTER 02/05]: xt_conntrack: fix missing boolean clamping Patrick McHardy
2008-02-27 20:10 ` David Miller
2008-02-27 13:14 ` [NETFILTER 03/05]: xt_conntrack: fix IPv4 address comparison Patrick McHardy
2008-02-27 20:20 ` David Miller
2008-02-27 13:14 ` [NETFILTER 04/05]: nf_nat: always select same SNAT source for same host Patrick McHardy
2008-02-27 16:31 ` Patrick McHardy
2008-02-27 20:07 ` David Miller
2009-01-13 14:24 ` Bernhard Schmidt
2008-02-27 13:14 ` [NETFILTER 05/05]: Fix NF_QUEUE_NR() parenthesis Patrick McHardy
2008-02-27 20:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080227.120915.54901797.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).