netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: davem@davemloft.net
Cc: Patrick McHardy <kaber@trash.net>, netfilter-devel@vger.kernel.org
Subject: [NETFILTER 02/03]: x_tables: fix net namespace leak when reading /proc/net/xxx_tables_names
Date: Tue, 29 Apr 2008 00:06:43 +0200 (MEST)	[thread overview]
Message-ID: <20080428220646.18270.5101.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20080428220643.18270.24909.sendpatchset@localhost.localdomain>

[NETFILTER]: x_tables: fix net namespace leak when reading /proc/net/xxx_tables_names

The seq_open_net() call should be accompanied with seq_release_net() one.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>

---
commit 6317c53b124105c288604f51d50e2c759f6f333b
tree dc91473a4ea1688a27c71f3a0336bfcee922b6c5
parent 409c904821b52f9c4597ca87f3ab01b55183904e
author Pavel Emelyanov <xemul@openvz.org> Tue, 29 Apr 2008 00:02:17 +0200
committer Patrick McHardy <kaber@trash.net> Tue, 29 Apr 2008 00:02:17 +0200

 net/netfilter/x_tables.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c
index f52f7f8..11b22ab 100644
--- a/net/netfilter/x_tables.c
+++ b/net/netfilter/x_tables.c
@@ -787,7 +787,7 @@ static const struct file_operations xt_table_ops = {
 	.open	 = xt_table_open,
 	.read	 = seq_read,
 	.llseek	 = seq_lseek,
-	.release = seq_release,
+	.release = seq_release_net,
 };
 
 static void *xt_match_seq_start(struct seq_file *seq, loff_t *pos)

  parent reply	other threads:[~2008-04-28 22:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-28 22:06 [NETFILTER 00/03]: Netfilter fixes Patrick McHardy
2008-04-28 22:06 ` [NETFILTER 01/03]: xt_TCPOPTSTRIP: signed tcphoff for ipv6_skip_exthdr() retval Patrick McHardy
2008-04-28 22:06 ` Patrick McHardy [this message]
2008-04-28 22:06 ` [NETFILTER 03/03]: {nfnetlink,ip,ip6}_queue: fix skb_over_panic when enlarging packets Patrick McHardy
2008-04-29 10:16 ` [NETFILTER 00/03]: Netfilter fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080428220646.18270.5101.sendpatchset@localhost.localdomain \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).