From: Patrick McHardy <kaber@trash.net>
To: davem@davemloft.net
Cc: Patrick McHardy <kaber@trash.net>, netfilter-devel@vger.kernel.org
Subject: netfilter 02/03: nf_conntrack_h323: fix memory leak in module initialization error path
Date: Tue, 17 Jun 2008 16:03:54 +0200 (MEST) [thread overview]
Message-ID: <20080617140353.1355.56759.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20080617140351.1355.59710.sendpatchset@localhost.localdomain>
netfilter: nf_conntrack_h323: fix memory leak in module initialization error path
Properly free h323_buffer when helper registration fails.
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit bed6cb858aec9a01eefee7fe4d3bfb7581da4863
tree 8e28d749ebef47da42f00b708b30c4df0e230363
parent 6a5696d1b52e24202682359b54775260fb4cbb54
author Patrick McHardy <kaber@trash.net> Tue, 17 Jun 2008 15:36:38 +0200
committer Patrick McHardy <kaber@trash.net> Tue, 17 Jun 2008 15:36:38 +0200
net/netfilter/nf_conntrack_h323_main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/netfilter/nf_conntrack_h323_main.c b/net/netfilter/nf_conntrack_h323_main.c
index 95da1a2..99e385d 100644
--- a/net/netfilter/nf_conntrack_h323_main.c
+++ b/net/netfilter/nf_conntrack_h323_main.c
@@ -1799,6 +1799,7 @@ err3:
err2:
nf_conntrack_helper_unregister(&nf_conntrack_helper_q931[0]);
err1:
+ kfree(h323_buffer);
return ret;
}
next prev parent reply other threads:[~2008-06-17 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 14:03 netfilter 00/03: netfilter fixes Patrick McHardy
2008-06-17 14:03 ` netfilter 01/03: nf_nat: fix RCU races Patrick McHardy
2008-06-17 14:03 ` Patrick McHardy [this message]
2008-06-17 14:03 ` netfilter 03/03: nf_conntrack_h323: fix module unload crash Patrick McHardy
2008-06-17 22:53 ` netfilter 00/03: netfilter fixes David Miller
-- strict thread matches above, loose matches on Subject: below --
2008-06-19 13:05 netfilter 00/03: netfilter -stable fixes Patrick McHardy
2008-06-19 13:05 ` netfilter 02/03: nf_conntrack_h323: fix memory leak in module initialization error path Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080617140353.1355.56759.sendpatchset@localhost.localdomain \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).