Linux Netfilter development
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: kaber@trash.net
Subject: [PATCH 1/6] [PATCH] use nf_conntrack_get instead of atomic_inc
Date: Sat, 11 Oct 2008 17:21:16 +0200	[thread overview]
Message-ID: <20081011152116.6436.17277.stgit@Decadence> (raw)

Use nf_conntrack_get instead of the direct call to atomic_inc.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

 net/netfilter/nf_conntrack_netlink.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index ff8deab..b7a6be8 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -1231,7 +1231,7 @@ ctnetlink_new_conntrack(struct sock *ctnl, struct sk_buff *skb,
 				goto out_unlock;
 			}
 			master_ct = nf_ct_tuplehash_to_ctrack(master_h);
-			atomic_inc(&master_ct->ct_general.use);
+			nf_conntrack_get(&master_ct->ct_general);
 		}
 
 		spin_unlock_bh(&nf_conntrack_lock);


             reply	other threads:[~2008-10-11 15:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-11 15:21 Pablo Neira Ayuso [this message]
2008-10-11 15:21 ` [PATCH 2/6] [PATCH] helper load-on-demand support for ctnetlink Pablo Neira Ayuso
2008-10-11 15:22 ` [PATCH 3/6] [PATCH] deliver events for conntracks created via ctnetlink Pablo Neira Ayuso
2008-10-11 15:22 ` [PATCH 4/6] [PATCH] bump the expectation helper name Pablo Neira Ayuso
2008-10-11 15:22 ` [PATCH 5/6] [PATCH] dynamic calculation of event message size for ctnetlink Pablo Neira Ayuso
2008-10-11 15:23 ` [PATCH 6/6] [PATCH] remove module dependency between ctnetlink and nf_nat Pablo Neira Ayuso
2008-10-13 13:50   ` Patrick McHardy
2008-10-13 14:06     ` Pablo Neira Ayuso
2008-10-13 14:08       ` Pablo Neira Ayuso
2008-10-13 14:11         ` Patrick McHardy
2008-10-13 14:11       ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081011152116.6436.17277.stgit@Decadence \
    --to=pablo@netfilter.org \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox