From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: netfilter 02/02: nf_conntrack_proto_gre: switch to register_pernet_gen_subsys()
Date: Thu, 30 Oct 2008 23:55:57 -0700 (PDT) [thread overview]
Message-ID: <20081030.235557.206473899.davem@davemloft.net> (raw)
In-Reply-To: <20081030073146.14487.64303.sendpatchset@x2.localnet>
From: Patrick McHardy <kaber@trash.net>
Date: Thu, 30 Oct 2008 08:31:47 +0100 (MET)
> netfilter: nf_conntrack_proto_gre: switch to register_pernet_gen_subsys()
>
> register_pernet_gen_device() can't be used is nf_conntrack_pptp module is
> also used (compiled in or loaded).
>
> Right now, proto_gre_net_exit() is called before nf_conntrack_pptp_net_exit().
> The former shutdowns and frees GRE piece of netns, however the latter
> absolutely needs it to flush keymap. Oops is inevitable.
>
> Switch to shiny new register_pernet_gen_subsys() to get correct ordering in
> netns ops list.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Also applied, thanks.
prev parent reply other threads:[~2008-10-31 6:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 7:31 netfilter 00/02: netfilter fixes Patrick McHardy
2008-10-30 7:31 ` netns 01/02: add register_pernet_gen_subsys/unregister_pernet_gen_subsys Patrick McHardy
2008-10-31 6:55 ` David Miller
2008-10-30 7:31 ` netfilter 02/02: nf_conntrack_proto_gre: switch to register_pernet_gen_subsys() Patrick McHardy
2008-10-31 6:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081030.235557.206473899.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).