From: Andy Whitcroft <apw@canonical.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org
Subject: Re: [PATCH 1/1] netfilter: ip{,6}t_policy.h should include xp_policy.h
Date: Thu, 20 Nov 2008 09:45:41 +0000 [thread overview]
Message-ID: <20081120094541.GA31575@shadowen.org> (raw)
In-Reply-To: <49245611.1080905@trash.net>
On Wed, Nov 19, 2008 at 07:08:17PM +0100, Patrick McHardy wrote:
> Andy Whitcroft wrote:
>> It seems that all of the include/netfilter_{ipv4,ipv6}/{ipt,ip6t}_*.h which
>> share constants include the corresponding include/netfilter/xp_*.h files.
>> Neither ipt_policy.h not ip6t_policy.h do. Make these consistant with
>> the norm.
>
> Does this actually fix a bug, or is it just for added consistency?
It was reported by an Ubuntu user who was compiling against them. From
my point of view it seemed clearly inconsistant and therefore most likely
wrong. So it seemed reasonable to fix it and push it upstream, if
there was a reason I was sure you'd soon put me straight.
-apw
next prev parent reply other threads:[~2008-11-20 9:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 16:21 [PATCH 1/1] netfilter: ip{,6}t_policy.h should include xp_policy.h Andy Whitcroft
2008-11-19 18:08 ` Patrick McHardy
2008-11-19 18:27 ` Jan Engelhardt
2008-11-19 18:38 ` Patrick McHardy
2008-11-20 9:45 ` Andy Whitcroft [this message]
2008-11-20 9:47 ` Patrick McHardy
2008-11-20 10:37 ` Andy Whitcroft
2008-11-20 10:38 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120094541.GA31575@shadowen.org \
--to=apw@canonical.com \
--cc=coreteam@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).