From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Whitcroft Subject: Re: [PATCH 1/1] netfilter: ip{,6}t_policy.h should include xp_policy.h Date: Thu, 20 Nov 2008 09:45:41 +0000 Message-ID: <20081120094541.GA31575@shadowen.org> References: <1227111682-14073-1-git-send-email-apw@canonical.com> <49245611.1080905@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org To: Patrick McHardy Return-path: Content-Disposition: inline In-Reply-To: <49245611.1080905@trash.net> Sender: netfilter-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On Wed, Nov 19, 2008 at 07:08:17PM +0100, Patrick McHardy wrote: > Andy Whitcroft wrote: >> It seems that all of the include/netfilter_{ipv4,ipv6}/{ipt,ip6t}_*.h which >> share constants include the corresponding include/netfilter/xp_*.h files. >> Neither ipt_policy.h not ip6t_policy.h do. Make these consistant with >> the norm. > > Does this actually fix a bug, or is it just for added consistency? It was reported by an Ubuntu user who was compiling against them. From my point of view it seemed clearly inconsistant and therefore most likely wrong. So it seemed reasonable to fix it and push it upstream, if there was a reason I was sure you'd soon put me straight. -apw