From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: Remove a noisy printk Date: Thu, 11 Dec 2008 20:32:43 -0800 (PST) Message-ID: <20081211.203243.124017657.davem@davemloft.net> References: <1229033625-30825-1-git-send-email-ajax@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, davej@redhat.com, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, kaber@trash.net To: ajax@redhat.com Return-path: In-Reply-To: <1229033625-30825-1-git-send-email-ajax@redhat.com> Sender: netdev-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org From: Adam Jackson Date: Thu, 11 Dec 2008 17:13:42 -0500 > From: Dave Jones > > These messages are trivial to trigger when running stress tests > like isic, and add no real value. > > Signed-off-by: Dave Jones > Signed-off-by: Adam Jackson If you don't send this to the netfilter developers nor the networking developers, noboby knowledgable can even look at this patch. CC:'d > --- > net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c b/net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c > index 4a7c352..0e86d0d 100644 > --- a/net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c > +++ b/net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c > @@ -147,8 +147,6 @@ static unsigned int ipv4_conntrack_local(unsigned int hooknum, > /* root is playing with raw sockets. */ > if (skb->len < sizeof(struct iphdr) || > ip_hdrlen(skb) < sizeof(struct iphdr)) { > - if (net_ratelimit()) > - printk("ipt_hook: happy cracking.\n"); > return NF_ACCEPT; > } > return nf_conntrack_in(dev_net(out), PF_INET, hooknum, skb); > -- > 1.6.0.3