From: Sam Ravnborg <sam@ravnborg.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>,
Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
urs.thuermann@volkswagen.de, oliver.hartkopp@volkswagen.de,
linux-media@vger.kernel.org, netfilter-devel@vger.kernel.org,
netfilter@vger.kernel.org, bfields@fieldses.org, neilb@suse.de,
linux-nfs@vger.kernel.org, linux-raid@vger.kernel.org,
dbrownell@users.sourceforge.net,
spi-devel-general@lists.sourceforge.net, netdev@vger.kernel.org,
greg@kroah.com, linux-usb@vger.kernel.org,
linux-mtd@lists.infradead.org, tiwai@suse.de,
mchehab@infradead.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings
Date: Sat, 17 Jan 2009 23:19:32 +0100 [thread overview]
Message-ID: <20090117221932.GA4956@uranus.ravnborg.org> (raw)
In-Reply-To: <1232228261.27094.0.camel@macbook.infradead.org>
On Sun, Jan 18, 2009 at 08:37:41AM +1100, David Woodhouse wrote:
> On Sun, 2009-01-18 at 01:47 +0530, Jaswinder Singh Rajput wrote:
> > --- a/include/linux/dvb/audio.h
> > +++ b/include/linux/dvb/audio.h
> > @@ -24,9 +24,8 @@
> > #ifndef _DVBAUDIO_H_
> > #define _DVBAUDIO_H_
> >
> > -#ifdef __KERNEL__
> > #include <linux/types.h>
> > -#else
> > +#ifndef __KERNEL__
> > #include <stdint.h>
> > #endif
> >
>
> That patch looks wrong, and unnecessary. It was fine before.
Nope - include/linux/dvb/audio.h failed to include linux/types.h
despite the fact that is uses __u32 etc.
But why the _kernel_ should include a userspace header is
much more questionable.
Sam
next prev parent reply other threads:[~2009-01-17 22:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-17 20:17 [GIT PULL -tip] fix 33 make headers_check warnings Jaswinder Singh Rajput
[not found] ` <1232223441.3966.22.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-01-17 21:37 ` David Woodhouse
2009-01-17 22:04 ` Jan Engelhardt
2009-01-17 22:19 ` Sam Ravnborg [this message]
2009-01-17 22:23 ` David Woodhouse
[not found] ` <1232230980.27094.15.camel-uXGAPMMVk8bAQYKIod7YupZV94DADvEd@public.gmane.org>
2009-01-18 2:46 ` Jaswinder Singh Rajput
2009-01-17 22:26 ` H. Peter Anvin
[not found] ` <49725B1E.604-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2009-01-21 0:38 ` Jaswinder Singh Rajput
2009-01-23 15:59 ` Jaswinder Singh Rajput
2009-01-23 16:04 ` Jaswinder Singh Rajput
2009-01-23 16:11 ` Jan Engelhardt
[not found] ` <alpine.LSU.2.00.0901231710350.15413-vVwEwcwQeYFPkBl3ERsXe1l1cybopEuJUBSOeVevoDU@public.gmane.org>
2009-01-23 16:21 ` Sam Ravnborg
2009-01-23 16:31 ` Jaswinder Singh Rajput
[not found] ` <1232728304.3504.28.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-01-23 17:09 ` Sam Ravnborg
2009-01-23 17:28 ` Jaswinder Singh Rajput
2009-01-23 21:33 ` H. Peter Anvin
[not found] ` <497A3793.5090502-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2009-01-23 21:54 ` Jan Engelhardt
2009-01-23 22:01 ` H. Peter Anvin
2009-01-18 3:05 ` Jaswinder Singh Rajput
2009-01-18 3:33 ` Kyle McMartin
[not found] ` <20090118033339.GA671-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org>
2009-01-18 3:38 ` Jaswinder Singh Rajput
[not found] ` <1232249904.3097.15.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-01-18 4:18 ` Kyle McMartin
[not found] ` <20090118041800.GB671-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org>
2009-01-23 15:56 ` Jaswinder Singh Rajput
2009-01-18 9:13 ` Ingo Molnar
[not found] ` <20090118091300.GA24849-X9Un+BFzKDI@public.gmane.org>
2009-01-18 10:10 ` Sam Ravnborg
2009-01-19 0:24 ` Stephen Rothwell
2009-01-19 2:53 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090117221932.GA4956@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=dbrownell@users.sourceforge.net \
--cc=dwmw2@infradead.org \
--cc=greg@kroah.com \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mingo@elte.hu \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=oliver.hartkopp@volkswagen.de \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=tiwai@suse.de \
--cc=urs.thuermann@volkswagen.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).