netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>,
	Patrick McHardy <kaber@trash.net>,
	netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [RFT 2/4] netfilter: remove unneeded initializations
Date: Wed, 28 Jan 2009 03:10:32 +0300	[thread overview]
Message-ID: <20090128001032.GA4034@x200.localdomain> (raw)
In-Reply-To: <20090127235508.827819940@vyatta.com>

On Tue, Jan 27, 2009 at 03:53:12PM -0800, Stephen Hemminger wrote:
> Later patches change the locking on xt_table and the initialization of
> the lock element is not needed since the lock is always initialized in
> xt_table_register anyway.

>  net/ipv4/netfilter/arptable_filter.c   |    2 --
>  net/ipv4/netfilter/iptable_filter.c    |    1 -
>  net/ipv4/netfilter/iptable_mangle.c    |    1 -
>  net/ipv4/netfilter/iptable_raw.c       |    1 -
>  net/ipv4/netfilter/iptable_security.c  |    1 -
>  net/ipv4/netfilter/nf_nat_rule.c       |    1 -
>  net/ipv6/netfilter/ip6table_filter.c   |    1 -
>  net/ipv6/netfilter/ip6table_mangle.c   |    1 -
>  net/ipv6/netfilter/ip6table_raw.c      |    1 -
>  net/ipv6/netfilter/ip6table_security.c |    1 -
>  10 files changed, 11 deletions(-)
> 
> --- a/net/ipv4/netfilter/arptable_filter.c
> +++ b/net/ipv4/netfilter/arptable_filter.c
> @@ -48,8 +48,6 @@ static struct
>  static struct xt_table packet_filter = {
>  	.name		= "filter",
>  	.valid_hooks	= FILTER_VALID_HOOKS,
> -	.lock		= __RW_LOCK_UNLOCKED(packet_filter.lock),

ACK and you can do the same for ebt_register_table() users.

  reply	other threads:[~2009-01-28  0:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-27 23:53 [RFT 0/4] Iptables rwlock elimination Stephen Hemminger
2009-01-27 23:53 ` [RFT 1/4] netfilter: change elements in x_tables Stephen Hemminger
2009-01-27 23:53 ` [RFT 2/4] netfilter: remove unneeded initializations Stephen Hemminger
2009-01-28  0:10   ` Alexey Dobriyan [this message]
2009-01-27 23:53 ` [RFT 3/4] netfilter: use sequence number synchronization for counters Stephen Hemminger
2009-01-28  6:17   ` Eric Dumazet
2009-01-28  6:28     ` Stephen Hemminger
2009-01-28  6:35       ` Eric Dumazet
2009-01-28 16:15         ` Patrick McHardy
2009-01-27 23:53 ` [RFT 4/4] netfilter: convert x_tables to use RCU Stephen Hemminger
2009-01-28  7:37   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090128001032.GA4034@x200.localdomain \
    --to=adobriyan@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).