From: Alexey Dobriyan <adobriyan@gmail.com>
To: Eric Leblond <eric@inl.fr>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] netfilter: log invalid new icmpv6 packet with nf_log_packet().
Date: Thu, 29 Jan 2009 23:47:54 +0300 [thread overview]
Message-ID: <20090129204754.GA22097@x200.localdomain> (raw)
In-Reply-To: <1233261382-17030-3-git-send-email-eric@inl.fr>
On Thu, Jan 29, 2009 at 09:36:22PM +0100, Eric Leblond wrote:
> --- a/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c
> +++ b/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c
> @@ -126,6 +126,10 @@ static bool icmpv6_new(struct nf_conn *ct, const struct sk_buff *skb,
> pr_debug("icmpv6: can't create new conn with type %u\n",
> type + 128);
> nf_ct_dump_tuple_ipv6(&ct->tuplehash[0].tuple);
> + if (LOG_INVALID(&init_net, IPPROTO_ICMPV6))
netns is nf_ct_net(ct) at this point, not &init_net.
> + nf_log_packet(PF_INET6, 0, skb, NULL, NULL, NULL,
> + "nf_ct_icmpv6: invalid new with type %d ",
> + type + 128);
next prev parent reply other threads:[~2009-01-29 20:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 20:36 [PATCH 0/2] fix invalid packet logging for icmpv6 conntrack Eric Leblond
2009-01-29 20:36 ` [PATCH 1/2] netfilter: fix nf_log_packet message in " Eric Leblond
2009-02-09 17:15 ` Patrick McHardy
2009-01-29 20:36 ` [PATCH 2/2] netfilter: log invalid new icmpv6 packet with nf_log_packet() Eric Leblond
2009-01-29 20:47 ` Alexey Dobriyan [this message]
2009-01-29 20:57 ` Eric Leblond
2009-01-29 20:59 ` [PATCH] " Eric Leblond
2009-02-09 17:17 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090129204754.GA22097@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=eric@inl.fr \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).