netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jengelh@medozas.de
Cc: arnd@arndb.de, hpa@zytor.com, sam@ravnborg.org,
	kyle@infradead.org, mingo@elte.hu, jaswinderrajput@gmail.com,
	mingo@redhat.com, dwmw2@infradead.org,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Re: [patch 5/7] make netfilter use strict integer types
Date: Wed, 25 Feb 2009 16:55:52 -0800 (PST)	[thread overview]
Message-ID: <20090225.165552.32040707.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LSU.2.00.0902260104220.20789@fbirervta.pbzchgretzou.qr>

From: Jan Engelhardt <jengelh@medozas.de>
Date: Thu, 26 Feb 2009 01:10:25 +0100 (CET)

> 
> On Thursday 2009-02-26 00:51, arnd@arndb.de wrote:
> 
> >Netfilter traditionally uses BSD integer types in its
> >interface headers. This changes it to use the Linux
> >strict integer types, like everyone else.
> 
> I _strongly disagree_ with this move. Userspace also has the uintX
> types via <stdint.h>/<cstdint>, and now you are adding a dependency
> on linux/types.h, not to mention that your step can lead to compile
> time piling up.
> 
> IMHO, __uXX should be replaced by uintX_t, but a move this great I
> will leave to future generations because there is just too much
> persisting opinions wrt. such proposal. As such I'd like to join
> and persist on my position and that uintX that we have should be kept.

Disagreed, I think we should have done what Arnd is doing
a long time ago.

Ending up with linux/types.h in userspace for these kinds of
interfaces is already a fore-gone conclusion, it happens
already whether you like it or not.

And existing apps will work just fine, since they are already
getting stdint.h

As for compile time, since you're already getting linux/types.h
in your apps it's a non-argument.  But even if it was, what
are you compiling netfilter utilities on?  A VAX?

  parent reply	other threads:[~2009-02-26  0:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090225235138.062045835@arndb.de>
2009-02-25 23:51 ` [patch 5/7] make netfilter use strict integer types arnd
2009-02-26  0:10   ` Jan Engelhardt
2009-02-26  0:14     ` H. Peter Anvin
2009-02-26  0:39       ` Jan Engelhardt
2009-02-26  1:02         ` H. Peter Anvin
2009-02-26  0:24     ` H. Peter Anvin
2009-02-26  0:55     ` David Miller [this message]
2009-02-26  0:58       ` H. Peter Anvin
2009-02-26  0:59         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090225.165552.32040707.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=arnd@arndb.de \
    --cc=coreteam@netfilter.org \
    --cc=dwmw2@infradead.org \
    --cc=hpa@zytor.com \
    --cc=jaswinderrajput@gmail.com \
    --cc=jengelh@medozas.de \
    --cc=kyle@infradead.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).