From: pud <pud@subnet666.de>
To: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: libxt_string: fix undefined behavior/incorrect patlen calculation
Date: Sun, 1 Mar 2009 23:37:35 +0100 [thread overview]
Message-ID: <20090301223735.GA25389@safeTpin.homeunix.org> (raw)
(sorry, msg-id lost)
> commit 19b0cd770d1e042c85bf0b278261a61d4cea8193
> Author: Jan Engelhardt <jeng...@medozas.de>
> Date: Thu Feb 12 01:18:35 2009 +0100
...
> - stringinfo->patlen=strlen((char *)&stringinfo->pattern);
> + stringinfo->patlen = strnlen((char *)&stringinfo->pattern,
> + sizeof(stringinfo->patlen));
sorry, this doesn't work here, did you mean
sizeof(stringinfo->pattern)?
=;p/ud aka nerdpunk
--
gpg-key #C3B04767
next reply other threads:[~2009-03-01 22:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-01 22:37 pud [this message]
2009-03-02 2:25 ` libxt_string: fix undefined behavior/incorrect patlen calculation Jan Engelhardt
2009-03-02 9:16 ` John Haxby
2009-03-02 10:48 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2009-02-12 0:21 Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090301223735.GA25389@safeTpin.homeunix.org \
--to=pud@subnet666.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).