From: David Miller <davem@davemloft.net>
To: eric@inl.fr
Cc: kaber@trash.net, sfr@canb.auug.org.au,
linux-next@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/3] netfilter: fix warning in ebt_ulog init function.
Date: Thu, 26 Mar 2009 01:04:09 -0700 (PDT) [thread overview]
Message-ID: <20090326.010409.92816273.davem@davemloft.net> (raw)
In-Reply-To: <1238054396-9088-2-git-send-email-eric@inl.fr>
From: Eric Leblond <eric@inl.fr>
Date: Thu, 26 Mar 2009 08:59:55 +0100
> The ebt_ulog module does not follow the fixed convention about function
> return. Loading the module is triggering the following message:
>
> sys_init_module: 'ebt_ulog'->init suspiciously returned 1, it should follow 0/-E convention
> sys_init_module: loading module anyway...
> Pid: 2334, comm: modprobe Not tainted 2.6.29-rc5edenwall0-00883-g199e57b #146
> Call Trace:
> [<c0441b81>] ? printk+0xf/0x16
> [<c02311af>] sys_init_module+0x107/0x186
> [<c0202cfa>] syscall_call+0x7/0xb
>
> The following patch fixes the return treatment in ebt_ulog_init()
> function.
>
> Signed-off-by: Eric Leblond <eric@inl.fr>
Applied.
next prev parent reply other threads:[~2009-03-26 8:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 6:37 linux-next: net tree build warnings Stephen Rothwell
2009-03-26 7:50 ` Eric Leblond
2009-03-26 7:59 ` [PATCH 1/3] netfilter: fix warning about invalid const usage Eric Leblond
2009-03-26 8:03 ` David Miller
2009-03-26 7:59 ` [PATCH 2/3] netfilter: fix warning in ebt_ulog init function Eric Leblond
2009-03-26 8:04 ` David Miller [this message]
2009-03-26 7:59 ` [PATCH 3/3] netfilter: fix nf_logger name in ebt_ulog Eric Leblond
2009-03-26 8:04 ` David Miller
2009-03-26 13:17 ` linux-next: net tree build warnings Patrick McHardy
2009-03-26 22:01 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090326.010409.92816273.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric@inl.fr \
--cc=kaber@trash.net \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).