From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrill Gorcunov Subject: Re: [patch 1/5] net: netfilter conntrack - add per-net functionality for ICMP protocol Date: Thu, 26 Mar 2009 19:59:28 +0300 Message-ID: <20090326165928.GE7950@localhost> References: <20090326160544.519118777@openvz.org> <20090326160711.826548855@openvz.org> <49CBAA5F.5020907@trash.net> <20090326163444.GA27855@x200.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Patrick McHardy , netfilter-devel@vger.kernel.org, xemul@openvz.org, daniel.lezcano@free.fr To: Alexey Dobriyan Return-path: Received: from ey-out-2122.google.com ([74.125.78.25]:24333 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759474AbZCZQ6v (ORCPT ); Thu, 26 Mar 2009 12:58:51 -0400 Received: by ey-out-2122.google.com with SMTP id 4so190752eyf.37 for ; Thu, 26 Mar 2009 09:58:48 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20090326163444.GA27855@x200.localdomain> Sender: netfilter-devel-owner@vger.kernel.org List-ID: [Alexey Dobriyan - Thu, Mar 26, 2009 at 07:34:44PM +0300] | On Thu, Mar 26, 2009 at 05:16:31PM +0100, Patrick McHardy wrote: | > Cyrill Gorcunov wrote: | >> Module specific data moved into per-net site and being allocated/freed | >> during net namespace creation/deletion. For this reason module_init/exit | >> calls added. | > | > This doesn't work. You can't have multiple module_init functions | > in one module and nf_connntrack_ivp4 already includes one. | | I thought all sysctl code would be generic in sense it will be done | during L3 and L4 proto registration, so all those ifdefs will be in one | place and so on. | It's a really good idea but it requires some logic to be changed -- for example I would need some kind of net-namespace sysctl hook so sysctl tables will be static and pinned to a particular source file and so on. Will think about. Thanks! Cyrill