From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org, xemul@openvz.org,
daniel.lezcano@free.fr, Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [patch 1/5] net: netfilter conntrack - add per-net functionality for ICMP protocol
Date: Thu, 26 Mar 2009 20:37:44 +0300 [thread overview]
Message-ID: <20090326173744.GG7950@localhost> (raw)
In-Reply-To: <49CBAA5F.5020907@trash.net>
[Patrick McHardy - Thu, Mar 26, 2009 at 05:16:31PM +0100]
> Cyrill Gorcunov wrote:
>> Module specific data moved into per-net site and being allocated/freed
>> during net namespace creation/deletion. For this reason module_init/exit
>> calls added.
>
> This doesn't work. You can't have multiple module_init functions
> in one module and nf_connntrack_ivp4 already includes one.
>
> Please test your patches with a modular built before resubmitting.
>
Btw, the patches
[patch 2/5] net: netfilter conntrack - add per-net functionality for SCTP protocol
[patch 5/5] net: netfilter conntrack - add per-net functionality for UDPLITE protocol
are not affected by multiple module_init/exit issue (except general idea
Alexey mentioned)
Cyrill
next prev parent reply other threads:[~2009-03-26 17:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 16:05 [patch 0/5] nf protos pernet functionality fresh attempt Cyrill Gorcunov
2009-03-26 16:05 ` [patch 1/5] net: netfilter conntrack - add per-net functionality for ICMP protocol Cyrill Gorcunov
2009-03-26 16:16 ` Patrick McHardy
2009-03-26 16:21 ` Cyrill Gorcunov
2009-03-26 16:34 ` Alexey Dobriyan
2009-03-26 16:59 ` Cyrill Gorcunov
2009-03-26 18:23 ` Cyrill Gorcunov
2009-03-26 21:05 ` Cyrill Gorcunov
2009-03-26 17:37 ` Cyrill Gorcunov [this message]
2009-03-26 16:05 ` [patch 2/5] net: netfilter conntrack - add per-net functionality for SCTP protocol Cyrill Gorcunov
2009-03-26 16:05 ` [patch 3/5] net: netfilter conntrack - add per-net functionality for TCP protocol Cyrill Gorcunov
2009-03-26 16:05 ` [patch 4/5] net: netfilter conntrack - add per-net functionality for UDP protocol Cyrill Gorcunov
2009-03-26 16:05 ` [patch 5/5] net: netfilter conntrack - add per-net functionality for UDPLITE protocol Cyrill Gorcunov
-- strict thread matches above, loose matches on Subject: below --
2009-03-28 22:33 [patch 0/5] nf conntrack protos pernet functionality v3 Cyrill Gorcunov
2009-03-28 22:33 ` [patch 1/5] net: netfilter conntrack - add per-net functionality for ICMP protocol Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090326173744.GG7950@localhost \
--to=gorcunov@gmail.com \
--cc=adobriyan@gmail.com \
--cc=daniel.lezcano@free.fr \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).