From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] netfilter: finer grained nf_conn locking Date: Sat, 28 Mar 2009 17:48:35 -0700 Message-ID: <20090328174835.0d0b63f8@nehalam> References: <20090218051906.174295181@vyatta.com> <20090218052747.679540125@vyatta.com> <499BDB5D.2050105@trash.net> <499C1894.7060400@cosmosbay.com> <49CE568A.9090104@cosmosbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Patrick McHardy , David Miller , Rick Jones , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org To: Eric Dumazet Return-path: Received: from mail.vyatta.com ([76.74.103.46]:52321 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297AbZC2Asm convert rfc822-to-8bit (ORCPT ); Sat, 28 Mar 2009 20:48:42 -0400 In-Reply-To: <49CE568A.9090104@cosmosbay.com> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Sat, 28 Mar 2009 17:55:38 +0100 Eric Dumazet wrote: > Eric Dumazet a =C3=A9crit : > > Patrick McHardy a =C3=A9crit : > >> Stephen Hemminger wrote: > >> > >>> @@ -50,6 +50,7 @@ struct ip_ct_tcp_state { > >>> =20 > >>> struct ip_ct_tcp > >>> { > >>> + spinlock_t lock; > >>> struct ip_ct_tcp_state seen[2]; /* connection parameters = per > >>> direction */ > >>> u_int8_t state; /* state of the connection (enum > >>> tcp_conntrack) */ > >>> /* For detecting stale connections */ > >> Eric already posted a patch to use an array of locks, which is > >> a better approach IMO since it keeps the size of the conntrack > >> entries down. > >=20 > > Yes, we probably can use an array for short lived lock sections. I am not a fan of the array of locks. Sizing it is awkward and it is vulnerable to hash collisions. Let's see if there is another better way. -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html