From: David Miller <davem@davemloft.net>
To: pablo@netfilter.org
Cc: netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: warnings in current tree
Date: Wed, 22 Apr 2009 02:27:22 -0700 (PDT) [thread overview]
Message-ID: <20090422.022722.82114710.davem@davemloft.net> (raw)
In-Reply-To: <49EDA5CE.4010108@netfilter.org>
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Tue, 21 Apr 2009 12:54:06 +0200
> Hi David!
>
> David Miller wrote:
>> From: David Miller <davem@davemloft.net>
>> Date: Tue, 21 Apr 2009 01:43:57 -0700 (PDT)
>>
>> Sorry, duh, meant netfilter-devel :-)
>>
>>> Can someone fix these up? Thanks!
>>>
>>> net/netfilter/nf_conntrack_netlink.c:1234: warning: 'helpname' may be used uninitialized in this function
>>> net/netfilter/nf_conntrack_netlink.c:991: warning: 'helpname' may be used uninitialized in this function
>
> Hm, weird, is this a "bogus punch"? I don't remember to have seen those
> here and that code has not been modified recently.
>
> Anyway, patch attached :).
Applied, thanks :-)
The problem is when you pass the address of a local variable
to a function, which is then inlined and has non-trivial
control flow (as far as GCC is concerned), and this is the
way the variable is initialized.
prev parent reply other threads:[~2009-04-22 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090421.014357.219275555.davem@davemloft.net>
2009-04-21 8:44 ` warnings in current tree David Miller
2009-04-21 10:54 ` Pablo Neira Ayuso
2009-04-22 9:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422.022722.82114710.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).