netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: kaber@trash.net
Subject: [PATCH] fix missing attribute in DCCP
Date: Wed, 22 Apr 2009 14:27:45 +0200	[thread overview]
Message-ID: <20090422122306.14461.55699.stgit@Decadence> (raw)

Hi Patrick,

While finishing the DCCP support (I think it's the last to finish
the conntrack-tools), I notice that there's one field that is
not exported to user-space via ctnetlink.

This patch adds a couple of missing attributes that allows me to
set the role in DCCP connections, otherwise the ctnetlink support
is not of much help to be used by conntrackd.

This can be done with only one attribute, so we can have just one
CTA_PROTOINFO_DCCP_ROLE_ORIGINAL and set the reply as the opposite.
However, this may look at bit inconsistent. I don't really mind
the way this is done, just tell me I'll do it :), but I need this
to complete DCCP support.

BTW, I think that this can be qualified as bugfix for 2.6.30-rc
since the current support is not of any help to create
conntrack entries with DCCP.

---

Pablo Neira Ayuso (1):
      netfilter: conntrack: add missing role attributes for DCCP


 include/linux/netfilter/nfnetlink_conntrack.h |    2 ++
 net/netfilter/nf_conntrack_proto_dccp.c       |   13 ++++++++++++-
 2 files changed, 14 insertions(+), 1 deletions(-)


             reply	other threads:[~2009-04-22 12:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22 12:27 Pablo Neira Ayuso [this message]
2009-04-22 12:28 ` [PATCH] netfilter: conntrack: add missing role attributes for DCCP Pablo Neira Ayuso
2009-04-22 13:44 ` [PATCH] fix missing attribute in DCCP Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090422122306.14461.55699.stgit@Decadence \
    --to=pablo@netfilter.org \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).