From: Ingo Molnar <mingo@elte.hu>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, akpm@linux-foundation.org,
torvalds@linux-foundation.org, davem@davemloft.net,
dada1@cosmosbay.com, zbr@ioremap.net, jeff.chua.linux@gmail.com,
paulus@samba.org, laijs@cn.fujitsu.com, jengelh@medozas.de,
r000n@r000n.net, benh@kernel.crashing.org,
mathieu.desnoyers@polymtl.ca
Subject: Re: [PATCH RFC] v1 expedited "big hammer" RCU grace periods
Date: Thu, 23 Apr 2009 09:54:36 +0200 [thread overview]
Message-ID: <20090423075436.GB22606@elte.hu> (raw)
In-Reply-To: <20090423052520.GA13036@linux.vnet.ibm.com>
* Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
> First cut of "big hammer" expedited RCU grace periods, but only
> for rcu_bh. This creates another softirq vector, so that entering
> this softirq vector will have forced an rcu_bh quiescent state (as
> noted by Dave Miller). Use smp_call_function() to invoke
> raise_softirq() on all CPUs in order to cause this to happen.
> Track the CPUs that have passed through a quiescent state (or gone
> offline) with a cpumask.
>
> Does nothing to expedite callbacks already registered with
> call_rcu_bh(), but there is no need to.
>
> Shortcomings:
>
> o Untested, probably does not compile, not for inclusion.
>
> o Does not handle rcu, only rcu_bh.
>
> Thoughts?
I'm wondering, why not just do a two-liner, along the lines of:
for_each_online_cpu(cpu)
smp_send_reschedule(cpu);
That should trigger a quiescent state on all online cpus. It wont
perturb the scheduler state (which is reschedule-IPI invariant).
(And this is a big-hammer approach anyway so even if it did we
wouldnt care.)
Am i missing something embarrasingly obvious perhaps?
Ingo
next prev parent reply other threads:[~2009-04-23 7:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 5:25 [PATCH RFC] v1 expedited "big hammer" RCU grace periods Paul E. McKenney
2009-04-23 6:11 ` Lai Jiangshan
2009-04-23 15:15 ` Paul E. McKenney
2009-04-24 0:39 ` Lai Jiangshan
2009-04-24 1:13 ` Paul E. McKenney
2009-04-23 7:54 ` Ingo Molnar [this message]
2009-04-23 15:34 ` Paul E. McKenney
2009-04-23 15:47 ` Linus Torvalds
2009-04-23 18:29 ` Paul E. McKenney
2009-04-23 13:45 ` Mathieu Desnoyers
2009-04-23 16:54 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090423075436.GB22606@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=jeff.chua.linux@gmail.com \
--cc=jengelh@medozas.de \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=r000n@r000n.net \
--cc=torvalds@linux-foundation.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).