netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kasprzak <kas@fi.muni.cz>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [RFD,patch] ICMP echo conntrack timeout
Date: Tue, 2 Jun 2009 14:47:21 +0200	[thread overview]
Message-ID: <20090602124721.GC3205@fi.muni.cz> (raw)
In-Reply-To: <4A251127.8000605@netfilter.org>

Pablo Neira Ayuso wrote:
: The only problem that I see is that you patch relaxes the current
: checking that we're doing. I mean, for every packet in one direction we
: only accept one ICMP reply packet. With your patch, we can accept more
: than one packet in the reply direction.

	I think it is perfectly legal, as we _want_ to se the duplicates,
if there are any.

-Yenya

-- 
| Jan "Yenya" Kasprzak  <kas at {fi.muni.cz - work | yenya.net - private}> |
| GPG: ID 1024/D3498839      Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E |
| http://www.fi.muni.cz/~kas/    Journal: http://www.fi.muni.cz/~kas/blog/ |
>> If we wanted to trade simplicity and kewl design for usability I think <<
>> we all know the URL of the Apple Store.               --jmorris42 @LWN <<

  reply	other threads:[~2009-06-02 12:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-01 17:43 [RFD,patch] ICMP echo conntrack timeout Jan Kasprzak
2009-06-02 11:46 ` Pablo Neira Ayuso
2009-06-02 12:47   ` Jan Kasprzak [this message]
2009-06-02 12:48   ` Patrick McHardy
2009-06-02 14:53     ` Pablo Neira Ayuso
2009-06-02 15:01       ` Patrick McHardy
2009-06-02 15:20         ` Pablo Neira Ayuso
2009-06-02 12:10 ` Patrick McHardy
2009-06-05 10:46 ` Patrick McHardy
2009-06-07  1:03   ` Jan Kasprzak
2009-06-08 13:54     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090602124721.GC3205@fi.muni.cz \
    --to=kas@fi.muni.cz \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).