From: Evgeniy Polyakov <zbr@ioremap.net>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Netfilter Development Mailinglist
<netfilter-devel@vger.kernel.org>,
Jan Engelhardt <jengelh@medozas.de>
Subject: Re: [resend] Passive OS fingerprint xtables match.
Date: Thu, 4 Jun 2009 16:07:19 +0400 [thread overview]
Message-ID: <20090604120719.GA14981@ioremap.net> (raw)
In-Reply-To: <4A27B5A1.9050300@trash.net>
On Thu, Jun 04, 2009 at 01:53:05PM +0200, Patrick McHardy (kaber@trash.net) wrote:
> >That's hard - there is no hook number in the match function, so we do
> >not really know if it is forward, input or prerouting.
>
> This is really needed, spamming the ring buffer is not a good option.
>
> I'd say just add the hook number to xt_match_param. Its a bit
> inconsistent anyways that we're handing it to checkentry for
> validation, but not to the match function.
Doesn't checkentry receive a mask of all possible hooks? There is still
no per-packet hook number. Although we can always use INPUT hook since
its the most widely used one. And drop a comment about this abuse.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2009-06-04 12:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 9:53 [resend] Passive OS fingerprint xtables match Evgeniy Polyakov
2009-05-27 16:28 ` Patrick McHardy
2009-05-29 8:59 ` Evgeniy Polyakov
2009-05-29 9:49 ` Jan Engelhardt
2009-05-29 10:20 ` Evgeniy Polyakov
2009-06-02 12:40 ` Patrick McHardy
2009-06-04 11:37 ` Evgeniy Polyakov
2009-06-04 11:53 ` Patrick McHardy
2009-06-04 12:07 ` Evgeniy Polyakov [this message]
2009-06-04 12:11 ` Patrick McHardy
2009-06-04 13:11 ` Evgeniy Polyakov
2009-06-04 13:16 ` Patrick McHardy
2009-06-04 13:30 ` Jan Engelhardt
2009-06-04 13:35 ` Patrick McHardy
2009-06-04 14:50 ` Evgeniy Polyakov
2009-06-04 14:55 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090604120719.GA14981@ioremap.net \
--to=zbr@ioremap.net \
--cc=davem@davemloft.net \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).