From: Florian Westphal <fw@strlen.de>
To: Patrick McHardy <kaber@trash.net>
Cc: Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org,
Holger Eitzenberger <heitzenberger@astaro.com>
Subject: Re: [PATCH 2/3] netfilter: NFQUEUE: queue balancing support
Date: Fri, 5 Jun 2009 15:35:25 +0200 [thread overview]
Message-ID: <20090605133525.GI29745@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <4A2900CE.5090004@trash.net>
Patrick McHardy <kaber@trash.net> wrote:
> Nice work, applied. I've made two minor cosmetic changes:
[..]
>> + return jhash2(addr, 4, jhash_initval);
>
> I changed 4 to ARRAY_SIZE(addr)
agreed.
>> + printk(KERN_ERR "NFQUEUE: number of queues (%u) out of range (got
>> %u)\n",
>> + info->queues_total, maxid);
>> + return false;
> and these printks to use pr_err to bring the line size down.
Indeed, it looks better that way :-)
Thanks a lot Patrick.
next prev parent reply other threads:[~2009-06-05 13:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 1:15 NFQUEUE balancing extension (kernel changes) Florian Westphal
2009-06-05 1:15 ` [PATCH 1/3] netfilter: NFQUEUE use NFPROTO_UNSPEC Florian Westphal
2009-06-05 11:19 ` Patrick McHardy
2009-06-05 1:15 ` [PATCH 2/3] netfilter: NFQUEUE: queue balancing support Florian Westphal
2009-06-05 9:50 ` Pablo Neira Ayuso
2009-06-05 10:43 ` Holger Eitzenberger
2009-06-05 11:26 ` Patrick McHardy
2009-06-05 13:35 ` Florian Westphal [this message]
2009-06-05 13:07 ` Jan Engelhardt
2009-06-05 13:23 ` Jan Engelhardt
2009-06-05 1:15 ` [PATCH 3/3] netfilter: MASQUERADE: remove redundant rwlock Florian Westphal
2009-06-05 11:27 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090605133525.GI29745@Chamillionaire.breakpoint.cc \
--to=fw@strlen.de \
--cc=heitzenberger@astaro.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).