From: Stephen Hemminger <shemminger@vyatta.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Netfilter Development Mailinglist
<netfilter-devel@vger.kernel.org>,
Martin Josefsson <gandalf@netfilter.org>
Subject: Re: RFC: conntrack: use mod_timer_pending()
Date: Wed, 10 Jun 2009 07:51:33 -0700 [thread overview]
Message-ID: <20090610075133.2dd04e7d@nehalam> (raw)
In-Reply-To: <4A2FAFF6.50909@trash.net>
On Wed, 10 Jun 2009 15:07:02 +0200
Patrick McHardy <kaber@trash.net> wrote:
> Patrick McHardy wrote:
> > This patch changes conntrack to use the new mod_timer_pending()
> > function, which only rearms the timer if it was still active.
> > This allows to only grab the lock in __nf_ct_refresh_acct when
> > accounting is used.
> >
> > Anyone seing anything wrong with this?
>
> > if (acct) {
> > + spin_lock_bh(&nf_conntrack_lock);
> > acct[CTINFO2DIR(ctinfo)].packets++;
> > acct[CTINFO2DIR(ctinfo)].bytes +=
> > skb->len - skb_network_offset(skb);
> > + spin_unlock_bh(&nf_conntrack_lock);
> > }
>
> In fact, we could additionally change it to use the per-conntrack lock.
That is what the conntrack RCU patch did.
next prev parent reply other threads:[~2009-06-10 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 13:05 RFC: conntrack: use mod_timer_pending() Patrick McHardy
2009-06-10 13:07 ` Patrick McHardy
2009-06-10 14:51 ` Stephen Hemminger [this message]
2009-06-10 14:53 ` Patrick McHardy
2009-06-10 15:07 ` Stephen Hemminger
2009-06-11 6:43 ` Martin Josefsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090610075133.2dd04e7d@nehalam \
--to=shemminger@vyatta.com \
--cc=gandalf@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).