From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Eric Leblond <eric@inl.fr>, Patrick McHardy <kaber@trash.net>
Cc: Maran Pakkirisamy <maranpsamy@in.ibm.com>,
Andreas Krebbel <krebbel1@de.ibm.com>,
<linux-kernel@vger.kernel.org>,
netfilter-devel@vger.kernel.org
Subject: netfilter: BUG: sleeping function called from invalid context
Date: Wed, 10 Jun 2009 16:19:35 +0200 [thread overview]
Message-ID: <20090610161935.0f8b1949@osiris.boeblingen.de.ibm.com> (raw)
Hi,
Maran reported the bug below (vanilla 2.6.30-rc8):
BUG: sleeping function called from invalid context at /mnt/s390test/linux-2.6-tip/arch/s390/include/asm/uaccess.h:234
in_atomic(): 1, irqs_disabled(): 0, pid: 3245, name: sysctl
CPU: 1 Not tainted 2.6.30-rc8-tipjun10-02053-g39ae214 #1
Process sysctl (pid: 3245, task: 000000007f675da0, ksp: 000000007eb17cf0)
0000000000000000 000000007eb17be8 0000000000000002 0000000000000000
000000007eb17c88 000000007eb17c00 000000007eb17c00 0000000000048156
00000000003e2de8 000000007f676118 000000007eb17f10 0000000000000000
0000000000000000 000000007eb17be8 000000000000000d 000000007eb17c58
00000000003e2050 000000000001635c 000000007eb17be8 000000007eb17c30
Call Trace:
(Ý<00000000000162e6>¨ show_trace+0x13a/0x148)
Ý<00000000000349ea>¨ __might_sleep+0x13a/0x164
Ý<0000000000050300>¨ proc_dostring+0x134/0x22c
Ý<0000000000312b70>¨ nf_log_proc_dostring+0xfc/0x188
Ý<0000000000136f5e>¨ proc_sys_call_handler+0xf6/0x118
Ý<0000000000136fda>¨ proc_sys_read+0x26/0x34
Ý<00000000000d6e9c>¨ vfs_read+0xac/0x158
Ý<00000000000d703e>¨ SyS_read+0x56/0x88
Ý<0000000000027f42>¨ sysc_noemu+0x10/0x16
The code that introduces the bug came in with 17625274 "netfilter:
sysctl support of logger choice".
There we have this chunk:
+ rcu_read_lock();
+ logger = rcu_dereference(nf_loggers[tindex]);
+ if (!logger)
+ table->data = "NONE";
+ else
+ table->data = logger->name;
+ r = proc_dostring(table, write, filp, buffer, lenp, ppos);
+ rcu_read_unlock();
proc_dostring() will call copy_from_user() while preemption is disabled
because of rcu_read_lock().
Looks like somebody needs to fix this ;)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2009-06-10 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 14:19 Heiko Carstens [this message]
2009-06-10 14:27 ` netfilter: BUG: sleeping function called from invalid context Patrick McHardy
[not found] ` <OFEF049E33.787CFA3F-ON652575D3.00227835-652575D3.00288292@in.ibm.com>
2009-06-13 9:42 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090610161935.0f8b1949@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=eric@inl.fr \
--cc=kaber@trash.net \
--cc=krebbel1@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maranpsamy@in.ibm.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).