netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rui Sousa <rui.p.m.sousa@gmail.com>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH] conntrack event missing TCP protoinfo
Date: Thu, 31 Dec 2009 14:03:21 +0100	[thread overview]
Message-ID: <200912311403.21983.rui.p.m.sousa@gmail.com> (raw)

Hi all,

Under some conditions it's possible to send a conntrack netlink event to 
userspace which is missing the TCP connection state 
(CDA_PROTOINFO_TCP_STATE) even though it is well defined.
This one liner should fix the problem. What do you think?

Br,
Rui

diff --git a/net/netfilter/nf_conntrack_proto_tcp.c b/net/netfilter/nf_conntrack_proto_tcp.c
index 3c96437..a514f5f 100644
--- a/net/netfilter/nf_conntrack_proto_tcp.c
+++ b/net/netfilter/nf_conntrack_proto_tcp.c
@@ -1045,6 +1045,7 @@ static int tcp_packet(struct nf_conn *ct,
 		   after SYN_RECV or a valid answer for a picked up
 		   connection. */
 		set_bit(IPS_ASSURED_BIT, &ct->status);
+		nf_conntrack_event_cache(IPCT_PROTOINFO, ct);
 		nf_conntrack_event_cache(IPCT_STATUS, ct);
 	}
 	nf_ct_refresh_acct(ct, ctinfo, skb, timeout);

             reply	other threads:[~2009-12-31 13:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-31 13:03 Rui Sousa [this message]
2009-12-31 18:09 ` [PATCH] conntrack event missing TCP protoinfo Pablo Neira Ayuso
2010-01-04 18:03   ` Rui Sousa
2010-01-05 19:19     ` Pablo Neira Ayuso
2010-01-05 20:39       ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200912311403.21983.rui.p.m.sousa@gmail.com \
    --to=rui.p.m.sousa@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).