From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Dobriyan Subject: Re: [PATCH 1/2] nfnetlink: add netns support Date: Wed, 13 Jan 2010 15:37:27 +0200 Message-ID: <20100113133727.GC16975@x200> References: <20100113122420.GA5790@x200> <4B4DC469.5000408@trash.net> <20100113132255.GA16975@x200> <4B4DCA2C.7020000@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org, containers@lists.linux-foundation.org To: Patrick McHardy Return-path: Received: from mail-fx0-f225.google.com ([209.85.220.225]:62531 "EHLO mail-fx0-f225.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292Ab0AMNhd (ORCPT ); Wed, 13 Jan 2010 08:37:33 -0500 Received: by fxm25 with SMTP id 25so159696fxm.21 for ; Wed, 13 Jan 2010 05:37:32 -0800 (PST) Content-Disposition: inline In-Reply-To: <4B4DCA2C.7020000@trash.net> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Wed, Jan 13, 2010 at 02:27:08PM +0100, Patrick McHardy wrote: > Alexey Dobriyan wrote: > > On Wed, Jan 13, 2010 at 02:02:33PM +0100, Patrick McHardy wrote: > >> Alexey Dobriyan wrote: > > > >>> + struct sock *nfnl; > >>> + struct sock *nfnl_stash; > >> Shouldn't this be contained in an ifdef(CONFIG_NETFILTER_NETLINK) > >> (_MODULE) ? > > > > No, otherwise you won't be able to start using, e. g., nfnetlink_log > > module on NETFILTER_NETLINK=n kernels without reboot. > > You mean after enabling CONFIG_NETFILTER_NETLINK? Yes, and it can't be directly enabled, because it's hidden option. > That seems like a pretty poor argument, you have to do a reboot after > changing a lot of config options. It's still a step back if I add #ifdef and a regression if you ask me. The price is only two pointers per-netns.