From: David Miller <davem@davemloft.net>
To: shanwei@cn.fujitsu.com
Cc: kaber@trash.net, yasuyuki.kozakai@toshiba.co.jp,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] IPv6: conntrack: Use protocol-related match routine in IPv6 connection track
Date: Mon, 25 Jan 2010 23:35:45 -0800 (PST) [thread overview]
Message-ID: <20100125.233545.219640402.davem@davemloft.net> (raw)
In-Reply-To: <4B5E53F4.4020106@cn.fujitsu.com>
From: Shan Wei <shanwei@cn.fujitsu.com>
Date: Tue, 26 Jan 2010 10:31:16 +0800
>
> IPv6 connection track and IPv6 stack separately use a different queue to
> manage received fragments. So using protocol-related match routine.
>
>
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
This problem was also introduced by:
commit 0b5ccb2ee250136dd7385b1c7da28417d0d4d32d
Author: Patrick McHardy <kaber@trash.net>
Date: Tue Dec 15 16:59:18 2009 +0100
ipv6: reassembly: use seperate reassembly queues for conntrack and local delivery
Currently the same reassembly queue might be used for packets reassembled
by conntrack in different positions in the stack (PREROUTING/LOCAL_OUT),
as well as local delivery. This can cause "packet jumps" when the fragment
completing a reassembled packet is queued from a different position in the
stack than the previous ones.
Add a "user" identifier to the reassembly queue key to seperate the queues
of each caller, similar to what we do for IPv4.
Signed-off-by: Patrick McHardy <kaber@trash.net>
prev parent reply other threads:[~2010-01-26 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 2:31 [PATCH 2/2] IPv6: conntrack: Use protocol-related match routine in IPv6 connection track Shan Wei
2010-01-26 7:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125.233545.219640402.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=shanwei@cn.fujitsu.com \
--cc=yasuyuki.kozakai@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).