From: Florian Westphal <fw@strlen.de>
To: Bart De Schuymer <bdschuym@pandora.be>
Cc: David Miller <davem@davemloft.net>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 0/7] netfilter: ebtables: CONFIG_COMPAT support
Date: Mon, 8 Feb 2010 00:28:36 +0100 [thread overview]
Message-ID: <20100207232836.GC27427@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <4B6F4A8E.4040507@pandora.be>
Bart De Schuymer <bdschuym@pandora.be> wrote:
> I think it's best to have the compat code in the fast path, since that's
> the code that will be needed in the future on those machines (I'll make
> the userspace workaround a compile-time option that is turned off by
> default in the next release of ebtables).
> Shouldn't it be possible for the compat code to know when a certain
> wrong size is due to the userspace workaround?
> If that situation is the
> case, then the compat code can execute the "native" getsockopt instead
> of producing a kernel error message...
This is what I plan to do in the next revision.
I'll send this particular change as a patch of its own
on top of the main compat hunk to ease review.
Thanks,
Florian
next prev parent reply other threads:[~2010-02-07 23:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 1:43 [PATCH 0/7] netfilter: ebtables: CONFIG_COMPAT support Florian Westphal
2010-02-05 1:43 ` [PATCH 1/7] netfilter: ebtables: abort if next_offset is too small Florian Westphal
2010-02-05 1:43 ` [PATCH 2/7] netfilter: ebtables: avoid explicit XT_ALIGN() in match/targets Florian Westphal
2010-02-05 1:43 ` [PATCH 3/7] netfilter: CONFIG_COMPAT: allow delta to exceed 32767 Florian Westphal
2010-02-05 1:43 ` [PATCH 4/7] netfilter: ebtables: split do_replace into two functions Florian Westphal
2010-02-05 1:43 ` [PATCH 5/7] netfilter: ebtables: add CONFIG_COMPAT support Florian Westphal
2010-02-05 13:52 ` Florian Westphal
2010-02-07 22:43 ` Florian Westphal
2010-02-05 1:43 ` [PATCH 6/7] netfilter: ebt_limit: " Florian Westphal
2010-02-05 1:43 ` [PATCH 7/7] netfilter: ebtables: mark: " Florian Westphal
2010-02-05 7:15 ` [PATCH 0/7] netfilter: ebtables: " Jan Engelhardt
2010-02-05 14:00 ` Florian Westphal
2010-02-05 17:15 ` Bart De Schuymer
2010-02-05 18:02 ` David Miller
2010-02-06 13:08 ` Bart De Schuymer
2010-02-06 13:50 ` Jan Engelhardt
2010-02-07 22:38 ` Florian Westphal
2010-02-07 23:19 ` Bart De Schuymer
2010-02-07 23:28 ` Florian Westphal [this message]
2010-02-05 19:53 ` Florian Westphal
2010-02-05 20:07 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100207232836.GC27427@Chamillionaire.breakpoint.cc \
--to=fw@strlen.de \
--cc=bdschuym@pandora.be \
--cc=davem@davemloft.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).