From: timg@tpi.com (Tim Gardner)
To: kaber@trash.net
Cc: coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
netfilter@vger.kernel.org
Subject: [PATCH] xt_recent: Fix false hit_count match
Date: Fri, 19 Feb 2010 10:49:04 -0700 (MST) [thread overview]
Message-ID: <20100219174904.1F62CF8C3F@sepang.rtg.net> (raw)
>From 146111514a8c126268e848e45b7dd967329b072f Mon Sep 17 00:00:00 2001
From: Tim Gardner <tim.gardner@canonical.com>
Date: Thu, 18 Feb 2010 20:33:00 -0700
Subject: [PATCH] xt_recent: Fix false match.
A rule with a zero hit_count will always match.
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Cc: stable@kernel.org
---
net/netfilter/xt_recent.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/xt_recent.c b/net/netfilter/xt_recent.c
index 1bb0d6c..43e83a4 100644
--- a/net/netfilter/xt_recent.c
+++ b/net/netfilter/xt_recent.c
@@ -260,7 +260,7 @@ recent_mt(const struct sk_buff *skb, const struct xt_match_param *par)
for (i = 0; i < e->nstamps; i++) {
if (info->seconds && time_after(time, e->stamps[i]))
continue;
- if (++hits >= info->hit_count) {
+ if (info->hit_count && ++hits >= info->hit_count) {
ret = !ret;
break;
}
--
1.6.2.4
next reply other threads:[~2010-02-19 18:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 17:49 Tim Gardner [this message]
2010-02-23 13:59 ` [PATCH] xt_recent: Fix false hit_count match Patrick McHardy
2010-03-19 15:04 ` Thomas Jarosch
2010-03-19 15:41 ` Patrick McHardy
2010-03-19 16:14 ` Tim Gardner
2010-03-19 16:19 ` Thomas Jarosch
2010-03-19 16:32 ` Patrick McHardy
2010-03-19 16:38 ` Tim Gardner
2010-03-22 17:31 ` Patrick McHardy
2010-03-22 19:14 ` Thomas Jarosch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100219174904.1F62CF8C3F@sepang.rtg.net \
--to=timg@tpi.com \
--cc=coreteam@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).