From: David Miller <davem@davemloft.net>
To: jengelh@medozas.de
Cc: ljaenicke@innominate.com, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/1] netfilter: nf_ct_tcp: pack nf_ct_tcp_flags to match user space
Date: Tue, 09 Mar 2010 09:41:16 -0800 (PST) [thread overview]
Message-ID: <20100309.094116.10935277.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LSU.2.01.1003091802060.3823@obet.zrqbmnf.qr>
From: Jan Engelhardt <jengelh@medozas.de>
Date: Tue, 9 Mar 2010 18:03:02 +0100 (CET)
> On Tuesday 2010-03-09 17:48, Lutz Jaenicke wrote:
>
>>On some platforms (here: Intel IXP4xx ARM big endian)
>>sizeof(struct nf_ct_tcp_flags) evaluates to 4 bytes while in the user
>>space code 2 bytes is hard coded.
>
> Why does it evaluate to 4 bytes? That seems to go against all good C
> practice.
It's just what the ARM ABI does.
We have to do something similar in the IPV6 stack for
the same reason.
struct nd_opt_hdr {
__u8 nd_opt_type;
__u8 nd_opt_len;
} __attribute__((__packed__));
next prev parent reply other threads:[~2010-03-09 17:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 16:48 [PATCH 0/1] Adjust nfnetlink structure size between kernel and user space Lutz Jaenicke
2010-03-09 16:48 ` [PATCH 1/1] netfilter: nf_ct_tcp: pack nf_ct_tcp_flags to match " Lutz Jaenicke
2010-03-09 17:02 ` Eric Dumazet
2010-03-09 17:18 ` Lutz Jaenicke
2010-03-09 17:03 ` Jan Engelhardt
2010-03-09 17:17 ` Lutz Jaenicke
2010-03-09 17:41 ` David Miller [this message]
2011-12-30 11:43 ` Lutz Jaenicke
2011-12-31 15:45 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2010-03-09 18:05 [PATCH 0/1] Adjust nfnetlink structure size between kernel and " Lutz Jaenicke
2010-03-09 18:05 ` [PATCH 1/1] netfilter: nf_ct_tcp: pack nf_ct_tcp_flags to match " Lutz Jaenicke
2010-03-15 16:57 ` Patrick McHardy
2010-03-15 18:04 ` Jan Engelhardt
2010-03-15 19:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309.094116.10935277.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jengelh@medozas.de \
--cc=ljaenicke@innominate.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).